{"prompt":"You are comparing an AI-suggested code fix with actual changes made in a commit.\n\nYour task: Determine if the commit contains the essence of the AI fix and provide a confidence level.\n\n## AI-Suggested Fix\n\n**What it fixes:** @forgerock/journey-client:lint\n\n**Description:** fix(journey-client): inline filter callback for prettier compliance\n\n**Reasoning:** The PR added a `.filter()` call spanning three lines with a trailing comma inside the callback argument:\n\n```ts\nconst providedIgnored: string[] = ignoredProperties.filter(\n (prop) => config[prop] !== undefined,\n);\n```\n\nPrettier's opinionated formatter determined this expression is short enough to fit on one line and therefore requires it to be written as:\n\n```ts\nconst providedIgnored: string[] = ignoredProperties.filter((prop) => config[prop] !== undefined);\n```\n\nThe ESLint rule `prettier/prett\n\n**Suggested Changes (diff):**\n```diff\ndiff --git a/packages/journey-client/src/lib/client.store.ts b/packages/journey-client/src/lib/client.store.ts\nindex b2560ca9d..cbd85480f 100644\n--- a/packages/journey-client/src/lib/client.store.ts\n+++ b/packages/journey-client/src/lib/client.store.ts\n@@ -101,9 +101,7 @@ export async function journey({\n 'type',\n ] as const;\n \n- const providedIgnored: string[] = ignoredProperties.filter(\n- (prop) => config[prop] !== undefined,\n- );\n+ const providedIgnored: string[] = ignoredProperties.filter((prop) => config[prop] !== undefined);\n \n if (config.serverConfig?.timeout !== undefined) {\n providedIgnored.push('serverConfig.timeout');\n\n```\n\n## Actual Commit Changes\n\n**Commit Diff:**\n```diff\ndiff --git a/.changeset/journey-client-config-alignment.md b/.changeset/journey-client-config-alignment.md\nnew file mode 100644\nindex 0000000000..63a7254776\n--- /dev/null\n+++ b/.changeset/journey-client-config-alignment.md\n@@ -0,0 +1,8 @@\n+---\n+'@forgerock/journey-client': patch\n+---\n+\n+Extend `JourneyClientConfig` from `AsyncLegacyConfigOptions` so the same config object can be shared across journey-client, davinci-client, and oidc-client\n+\n+- `clientId`, `scope`, `redirectUri`, and other inherited properties are now accepted but ignored — a warning is logged when they are provided\n+- `serverConfig.wellknown` remains required\ndiff --git a/packages/journey-client/src/lib/client.store.test.ts b/packages/journey-client/src/lib/client.store.test.ts\nindex 5504347a17..f57a1c0f7c 100644\n--- a/packages/journey-client/src/lib/client.store.test.ts\n+++ b/packages/journey-client/src/lib/client.store.test.ts\n@@ -359,6 +359,71 @@ describe('journey-client', () => {\n });\n });\n \n+ describe('config property warnings', () => {\n+ test('journey_ExtraConfigProperties_LogsWarning', async () => {\n+ setupMockFetch();\n+ const customLogger = {\n+ error: vi.fn(),\n+ warn: vi.fn(),\n+ info: vi.fn(),\n+ debug: vi.fn(),\n+ };\n+\n+ await journey({\n+ config: {\n+ serverConfig: { wellknown: mockWellknownUrl },\n+ clientId: 'test-client',\n+ scope: 'openid',\n+ redirectUri: 'https://example.com/callback',\n+ },\n+ logger: { level: 'warn', custom: customLogger },\n+ });\n+\n+ expect(customLogger.warn).toHaveBeenCalledTimes(1);\n+ expect(customLogger.warn).toHaveBeenCalledWith(expect.stringContaining('clientId'));\n+ expect(customLogger.warn).toHaveBeenCalledWith(expect.stringContaining('scope'));\n+ expect(customLogger.warn).toHaveBeenCalledWith(expect.stringContaining('redirectUri'));\n+ });\n+\n+ test('journey_SingleIgnoredProperty_LogsWarning', async () => {\n+ setupMockFetch();\n+ const customLogger = {\n+ error: vi.fn(),\n+ warn: vi.fn(),\n+ info: vi.fn(),\n+ debug: vi.fn(),\n+ };\n+\n+ await journey({\n+ config: {\n+ serverConfig: { wellknown: mockWellknownUrl },\n+ clientId: 'test-client',\n+ },\n+ logger: { level: 'warn', custom: customLogger },\n+ });\n+\n+ expect(customLogger.warn).toHaveBeenCalledTimes(1);\n+ expect(customLogger.warn).toHaveBeenCalledWith(expect.stringContaining('clientId'));\n+ });\n+\n+ test('journey_MinimalConfig_NoWarning', async () => {\n+ setupMockFetch();\n+ const customLogger = {\n+ error: vi.fn(),\n+ warn: vi.fn(),\n+ info: vi.fn(),\n+ debug: vi.fn(),\n+ };\n+\n+ await journey({\n+ config: { serverConfig: { wellknown: mockWellknownUrl } },\n+ logger: { level: 'warn', custom: customLogger },\n+ });\n+\n+ expect(customLogger.warn).not.toHaveBeenCalled();\n+ });\n+ });\n+\n describe('subrealm inference', () => {\n test('journey_WellknownWithSubrealm_DerivesCorrectPaths', async () => {\n const alphaConfig: JourneyClientConfig = {\ndiff --git a/packages/journey-client/src/lib/client.store.ts b/packages/journey-client/src/lib/client.store.ts\nindex 10fad05d89..cbd85480f2 100644\n--- a/packages/journey-client/src/lib/client.store.ts\n+++ b/packages/journey-client/src/lib/client.store.ts\n@@ -50,7 +50,7 @@ export interface JourneyClient {\n * It uses AM-proprietary endpoints for callback-based authentication trees.\n *\n * @param options - Configuration options for the journey client\n- * @param options.config - Server configuration with required wellknown URL\n+ * @param options.config - Configuration options (see {@link JourneyClientConfig}); only `serverConfig.wellknown` is required\n * @param options.requestMiddleware - Optional middleware for request customization\n * @param options.logger - Optional logger configuration\n * @returns A journey client instance\n@@ -86,6 +86,33 @@ export async function journey({\n }): Promise {\n const log = loggerFn({ level: logger?.level || 'error', custom: logger?.custom });\n \n+ const ignoredProperties = [\n+ 'callbackFactory',\n+ 'clientId',\n+ 'middleware',\n+ 'oauthThreshold',\n+ 'platformHeader',\n+ 'prefix',\n+ 'realmPath',\n+ 'redirectUri',\n+ 'scope',\n+ 'tokenStore',\n+ 'tree',\n+ 'type',\n+ ] as const;\n+\n+ const providedIgnored: string[] = ignoredProperties.filter((prop) => config[prop] !== undefined);\n+\n+ if (config.serverConfig?.timeout !== undefined) {\n+ providedIgnored.push('serverConfig.timeout');\n+ }\n+\n+ if (providedIgnored.length > 0) {\n+ log.warn(\n+ `The following configuration properties are not used by journey-client and will be ignored: ${providedIgnored.join(', ')}`,\n+ );\n+ }\n+\n const store = createJourneyStore({ requestMiddleware, logger: log });\n \n const { wellknown } = config.serverConfig;\ndiff --git a/packages/journey-client/src/lib/config.types.test-d.ts b/packages/journey-client/src/lib/config.types.test-d.ts\nnew file mode 100644\nindex 0000000000..d314f040fe\n--- /dev/null\n+++ b/packages/journey-client/src/lib/config.types.test-d.ts\n@@ -0,0 +1,72 @@\n+/*\n+ * Copyright (c) 2025 Ping Identity Corporation. All rights reserved.\n+ *\n+ * This software may be modified and distributed under the terms\n+ * of the MIT license. See the LICENSE file for details.\n+ */\n+import { describe, expectTypeOf, it } from 'vitest';\n+import type {\n+ JourneyClientConfig,\n+ JourneyServerConfig,\n+ InternalJourneyClientConfig,\n+} from './config.types.js';\n+import type { AsyncLegacyConfigOptions } from '@forgerock/sdk-types';\n+import type { ResolvedServerConfig } from './wellknown.utils.js';\n+\n+describe('Config Types', () => {\n+ describe('JourneyClientConfig', () => {\n+ it('should extend AsyncLegacyConfigOptions', () => {\n+ expectTypeOf().toExtend();\n+ });\n+\n+ it('should narrow serverConfig to JourneyServerConfig', () => {\n+ expectTypeOf().toExtend();\n+ expectTypeOf().toBeString();\n+ });\n+\n+ it('should reject config without wellknown', () => {\n+ // @ts-expect-error - wellknown is required on serverConfig\n+ const config: JourneyClientConfig = { serverConfig: {} };\n+ // This assertion verifies the variable's runtime shape doesn't satisfy the full type.\n+ expectTypeOf(config).not.toMatchObjectType>();\n+ });\n+\n+ it('should allow AsyncLegacyConfigOptions properties', () => {\n+ const config: JourneyClientConfig = {\n+ clientId: 'test-client',\n+ scope: 'openid profile',\n+ redirectUri: 'https://app.example.com/callback',\n+ serverConfig: {\n+ wellknown: 'https://am.example.com/am/oauth2/alpha/.well-known/openid-configuration',\n+ timeout: 30000,\n+ },\n+ };\n+ expectTypeOf(config).toExtend();\n+ });\n+\n+ it('should not require inherited properties like clientId', () => {\n+ const config: JourneyClientConfig = {\n+ serverConfig: {\n+ wellknown: 'https://am.example.com/am/oauth2/alpha/.well-known/openid-configuration',\n+ },\n+ };\n+ expectTypeOf(config).toExtend();\n+ });\n+\n+ it('should have optional timeout on serverConfig', () => {\n+ expectTypeOf().toHaveProperty('timeout');\n+ });\n+ });\n+\n+ describe('InternalJourneyClientConfig', () => {\n+ it('should have ResolvedServerConfig', () => {\n+ expectTypeOf()\n+ .toHaveProperty('serverConfig')\n+ .toExtend();\n+ });\n+\n+ it('should have optional error', () => {\n+ expectTypeOf().toHaveProperty('error').toBeNullable();\n+ });\n+ });\n+});\ndiff --git a/packages/journey-client/src/lib/config.types.ts b/packages/journey-client/src/lib/config.types.ts\nindex cecb97ea07..25eaeaa888 100644\n--- a/packages/journey-client/src/lib/config.types.ts\n+++ b/packages/journey-client/src/lib/config.types.ts\n@@ -5,7 +5,7 @@\n * of the MIT license. See the LICENSE file for details.\n */\n \n-import type { GenericError } from '@forgerock/sdk-types';\n+import type { AsyncLegacyConfigOptions, GenericError } from '@forgerock/sdk-types';\n import type { ResolvedServerConfig } from './wellknown.utils.js';\n \n /**\n@@ -17,11 +17,18 @@ import type { ResolvedServerConfig } from './wellknown.utils.js';\n export interface JourneyServerConfig {\n /** Required OIDC discovery endpoint URL */\n wellknown: string;\n+ /** Optional request timeout in milliseconds. Included for config-sharing compatibility with other clients. */\n+ timeout?: number;\n }\n \n /**\n * Configuration for creating a journey client instance.\n *\n+ * Extends {@link AsyncLegacyConfigOptions} so that the same config object can\n+ * be shared across journey-client, davinci-client, and oidc-client. Properties\n+ * like `clientId`, `scope`, and `redirectUri` are accepted but not used by\n+ * journey-client — a warning is logged when they are provided.\n+ *\n * @example\n * ```typescript\n * const config: JourneyClientConfig = {\n@@ -31,7 +38,7 @@ export interface JourneyServerConfig {\n * };\n * ```\n */\n-export interface JourneyClientConfig {\n+export interface JourneyClientConfig extends AsyncLegacyConfigOptions {\n serverConfig: JourneyServerConfig;\n }\n \n\n```\n\n## Instructions\n\nRate how similar the commit is to the AI fix on a scale of 0-10.\n\n**Scoring Guide:**\n- 10: Nearly identical changes (same files, same logic, same fixes)\n- 8-9: Very similar (same core changes, minor differences in implementation)\n- 6-7: Similar intent (addresses same issue, somewhat different approach)\n- 4-5: Some overlap (touches same area, but different changes)\n- 2-3: Minimal similarity (different files or completely different changes)\n- 0-1: No similarity (unrelated changes)\n\n**Criteria:**\n- Focus on: same files modified, similar logic changes, same bug being fixed\n- The commit may have additional changes beyond the AI fix - that's okay\n- Small differences in implementation are okay if the intent is the same\n\nProvide your score (0-10) and a brief reasoning (2-3 sentences) explaining your assessment.","response":"{\"score\":7,\"reasoning\":\"The commit does contain the exact change suggested by the AI fix - the filter callback on lines 101-103 of client.store.ts is inlined from a multi-line format to a single line, matching the prettier compliance fix perfectly. However, the commit is substantially larger, adding feature implementation (config property warnings, type extensions, tests) that goes well beyond the scope of the AI's lint fix suggestion. The core lint fix is present and correct, but represents only a small portion of the overall commit changes.\"}","model":"claude-haiku-4-5-20251001","cipeFixId":"69cd2ccaed8aec32f6d910c6","headSha":"5fe2f4157249111d77b7d29d09535e56f79120cf","timestamp":1775061037759}