Overview - Ping-javascript-sdk

ping-javascript-sdk

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Failed
603
Fix ready→
a358a2d9 fix(davinci-suites): support two phone collectors in form-fields e2e The PingOne form now renders two PhoneNumberCollector instances ("Phone" and "Phone Number w/Extension"). Both rendered with hardcoded id="phone-number-input", producing duplicate IDs in the DOM and triggering a Playwright strict-mode violation on `page.locator('#phone-number-input').fill(...)`. Two fixes: - e2e/davinci-app/components/object-value.ts: derive the input id from `collector.output.key` so each phone field gets a unique id and its label associates with the correct input (also fixes a real HTML invalidity). - e2e/davinci-suites/src/form-fields.test.ts: replace the CSS-selector lookup with `getByLabel('Phone', { exact: true })` so the test selects an input by its accessible name, and update the expected `formData` to include both phone collectors — phone-field carries the prefilled "(555)555-1234"/GB, phone-field1 receives the typed "1234567890"/CR.
by Ryan Bas