Overview - Adt-cli

adt-cli

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
copilot/fix-unix-specific-find-command
cb10d1b5 security: resolve adt binary by walking up node_modules/.bin Addresses SonarCloud security hotspot typescript:S4036 (Using shell interpreters when executing OS commands) introduced by the previous `bunx`-based invocation, which resolved the binary via the user's PATH. Add a tiny `findHoistedBin(name, startDir)` helper that walks up from `ctx.cwd` looking for `node_modules/.bin/<name>` (with the `.cmd` suffix on Windows) and returns an absolute, existsSync-verified path. The adt CLI is then launched with that absolute path, so: * PATH contents can no longer influence which binary is executed (resolves the Sonar S4036 hotspot). * bun-workspace monorepos still work — the helper walks up exactly as npm/bunx would, finding the hoisted binary at the workspace root (keeps Devin's original review fix). * Windows `.cmd` shims are still handled via `shell: true` gated to win32 per Node's child_process docs.
by Petr Plenkov
Succeeded
copilot/fix-unix-specific-find-command
ed22d7d5 review: use bunx for adt CLI invocation (monorepo hoisting) Addresses Devin Review finding on PR #114: resolving `node_modules/.bin/adt` relative to `ctx.cwd` fails in bun-workspaces monorepos where binaries are hoisted to the workspace root. Running `adt contracts` from a sub-package then throws ENOENT. Switch to `execFileSync('bunx', ['adt', …])` — `bunx` is the AGENTS.md-sanctioned convention for this repo and walks up the directory tree exactly as the old `npx` call did. `shell: true` stays platform-gated: enabled on Windows (bunx is a `.cmd` shim there), shell-free on POSIX.
by Petr Plenkov
Succeeded
copilot/fix-unix-specific-find-command
e1146533 review: normalise resolver paths to POSIX separators Addresses Copilot Reviewer finding on PR #114: `collectSourceFiles()` produced paths joined with the platform separator (`\\` on Windows), but `ResolvedLocation.path` is documented as a git-relative path and consumed by the GitLab JSON + SARIF formatters, both of which expect POSIX (`/`) separators. Add a tiny `toPosix()` helper that only rewrites on platforms where `path.sep !== '/'`, and use it when inserting into the filename → path lookup. Downstream reads via `readFileSync` are unaffected (Node accepts `/` on Windows).
by Petr Plenkov
Succeeded
copilot/fix-unix-specific-find-command
dc08479e quality: dedupe abapGit finding resolver (adt-plugin-abapgit → adt-atc) Addresses the SonarCloud duplication gate on PR #114 (new_duplicated_lines_density = 63% > 3% threshold). `packages/adt-plugin-abapgit/src/lib/finding-resolver.ts` had copy-pasted the entire `collectSourceFiles`, `getFileLines`, `parseMethodRanges`, `convertLine` and resolver-factory from `packages/adt-atc/src/resolvers/abapgit.ts` (adt-plugin-abapgit already depends on @abapify/adt-atc for the `FindingResolver` type, so the copy is pure duplication). * Export `createAbapGitResolver` from `@abapify/adt-atc` so it becomes part of the package's public API. * Replace the plugin file with a one-line re-export: `export { createAbapGitResolver as createFindingResolver } from '@abapify/adt-atc'`. Public API of @abapify/adt-plugin-abapgit (`createFindingResolver`) is unchanged. This also implicitly resolves the two MINOR S7772 `node:path` findings and the second CRITICAL S2871 `.sort()` finding that existed in the plugin copy — a single canonical implementation now carries the fixes from the previous commit.
by Petr Plenkov
Succeeded
copilot/fix-unix-specific-find-command
d5b85f6a review: harden detectGithubRepo (SCP vs URL, dotted repos, shell-safe owner/repo) Addresses two bot review findings on PR #115: * Devin Review — the SCP-style regex `^[^@\s]+@([^:]+):(.+)$` falsely matched URL-form remotes that contain both `user@` and a `:port` segment, e.g. `ssh://git@github.com:22/abapify/adt-cli.git`. The port was captured as part of the path and then rejected by parseOwnerRepo, silently disabling trusted-publisher auto-detection. The SCP branch is now skipped whenever the input contains `://`, so URL-form remotes fall through to `new URL()`. * CodeRabbit — the previous shape regex `[^/]+/[^/.]+?` rejected valid GitHub repos with dots in the name (e.g. `owner/repo.name`) and accepted shell metacharacters in the owner segment. The value flows unquoted into a shell command at `plugin.ts` line ~126 (`--trust-repo=${trustRepo}`), so a strict allow-list is enforced before return: `^[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+$`. This accepts dotted repos and rejects anything that could be interpreted by a shell.
by Petr Plenkov
Succeeded
copilot/fix-unix-specific-find-command
b960756e fix(aclass): qualified method names + keyword method names Responses to the 3 Devin findings that arrived after my previous fix batch. Root cause of both: `parseMethodDecl` / `parseMethodImpl` consumed only a single identifier token as the method name. ## 🔴 Method name = ABAP keyword (e.g. `to`) Both `parseMethodImpl` and `parseMethodDecl` used the strict `nameTok.tokenType.name !== 'Identifier'` check. The word `to` is the `To` keyword (used in `REF TO`, `OF TABLE`, …), so `METHOD to.` — present in `zcl_petstore3.clas.locals_imp.abap:152` — silently dropped the method from the AST. Fix: both sites now use the existing `isNameLike()` type-guard (same approach already applied to attribute / parameter / struct-field names in the previous commit). ## 🟡 Qualified method names (`zif_foo~bar`) truncated `parseMethodImpl` read only `header.tokens[1]`, so `METHOD zif_petstore3~add_pet.` landed with `name: 'zif_petstore3'`. All 19 interface method implementations in the generated `zcl_petstore3.clas.abap` were affected; the body was fine (offset- based slicing) but the AST `MethodImpl.name` was wrong, breaking any consumer that indexes methods by name. Fix: extracted a `readQualifiedName(toks, start)` helper that walks `<name>(~|=>)<name>…` chains (reusing the same pattern `consumeTypeRef` uses for qualified type names), and applied it to both `parseMethodImpl` and `parseMethodDecl` (the latter also handles `METHODS zif_foo~bar REDEFINITION.`). ## Tests - New test: `MethodImpl` of `METHOD zif_petstore3~add_pet.` yields `name === 'zif_petstore3~add_pet'`. - New test: `METHODS zif_foo~bar REDEFINITION.` yields `name === 'zif_foo~bar'` with `isRedefinition === true`. Verified on the petstore3 corpus: the 20 `MethodImpl` nodes in `zcl_petstore3.clas.abap` now show `constructor` + 19 fully-qualified `zif_petstore3~<op>` names. Live TRL (CB9980002179, us10): deploy → activate → 3/3 AUnit pass. Tests: aclass 51/51, openai-codegen 159/159, abap-ast 115/115. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
by Petr Plenkov
Succeeded
copilot/fix-unix-specific-find-command
9cb558c4 fix: harden cross-platform resolver traversal and adt command execution Agent-Logs-Url: https://github.com/abapify/adt-cli/sessions/35ac2aa7-39f5-4cd6-ba9e-557241389cca Co-authored-by: ThePlenkov <6381507+ThePlenkov@users.noreply.github.com>
by copilot-sw...
Succeeded
copilot/fix-unix-specific-find-command
bace2cae fix: address validation feedback for quote stripping and adt binary path Agent-Logs-Url: https://github.com/abapify/adt-cli/sessions/35ac2aa7-39f5-4cd6-ba9e-557241389cca Co-authored-by: ThePlenkov <6381507+ThePlenkov@users.noreply.github.com>
by copilot-sw...
Succeeded
copilot/fix-unix-specific-find-command
eed8fb35 ci: split Nx Cloud token into RO/RW repo secrets, drop environments Using GitHub Environments to scope the read-write Nx Cloud token to `main` pushes caused every workflow run to be registered as a "deployment" in the GitHub UI, which was misleading — these workflows don't deploy anything. Switch to two plain repository secrets: * `NX_CLOUD_ACCESS_TOKEN_RO` — read-only token, safe to expose on PRs and feature branches. * `NX_CLOUD_ACCESS_TOKEN_RW` — read-write token, injected only when we actually need to write to the remote cache. In `ci.yml` the token is selected via a gated expression so PRs get RO and pushes to `main` get RW. `release.yml`, `publish.yml` and `publish-gpr.yml` always run against `main`/tags, so they hardcode RW. The `protected-branch-pipeline` and `unprotected-branch-pipeline` environments have been deleted along with this change. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
by Petr Plenkov
Succeeded
copilot/fix-unix-specific-find-command
14fa6b72 fix: apply cross-platform scanning and runtime configurability updates Agent-Logs-Url: https://github.com/abapify/adt-cli/sessions/35ac2aa7-39f5-4cd6-ba9e-557241389cca Co-authored-by: ThePlenkov <6381507+ThePlenkov@users.noreply.github.com>
by copilot-sw...
Succeeded
copilot/fix-unix-specific-find-command
7ce4129d chore: outline plan for cross-platform and plugin fixes Agent-Logs-Url: https://github.com/abapify/adt-cli/sessions/35ac2aa7-39f5-4cd6-ba9e-557241389cca Co-authored-by: ThePlenkov <6381507+ThePlenkov@users.noreply.github.com>
by copilot-sw...
Succeeded
copilot/fix-unix-specific-find-command
5f82e6a5 Initial plan
by copilot-sw...