Overview - Adt-cli

adt-cli

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
add-adk-unit-tests
b3c0279e review(adk tests): fix toText expectations, isolate registry state Fetch-utils: - toText JSON-stringifies plain objects (source at fetch-utils.ts:26-28), so the two assertions that expected '[object Object]' were wrong and failed CI. Corrected to the actual JSON output. - Added a circular-reference test to cover the JSON.stringify catch branch, which is the only case that actually produces '[object Object]'. Registry: - Added __resetRegistryForTests() so tests get a clean singleton each time; called from beforeEach. Removes order-dependence and prevents bleed-in from module-load-time registerObjectType() calls in src/objects/**. - getRegisteredTypes empty-array test now asserts toEqual([]) instead of Array.isArray (meaningful only after reset is in place). - Extracted MockAdkObject -> AdkObjectConstructor cast into a single `mockCtor` helper; drops 10+ `as any` occurrences. - Renamed kinds_list -> kindsList (camelCase). - Fixed stray space in 'abap/ programs' -> 'abap/programs'. - Clarified isTypeRegistered test name to reflect what it actually asserts (full types are registered when main type is). Addresses findings from CodeRabbit, Copilot, Devin Review, and Qodo on #97.
by Petr Plenkov
Failed
add-adk-unit-tests
80518332 security: resolve adt binary by walking up node_modules/.bin Addresses SonarCloud security hotspot typescript:S4036 (Using shell interpreters when executing OS commands) introduced by the previous `bunx`-based invocation, which resolved the binary via the user's PATH. Add a tiny `findHoistedBin(name, startDir)` helper that walks up from `ctx.cwd` looking for `node_modules/.bin/<name>` (with the `.cmd` suffix on Windows) and returns an absolute, existsSync-verified path. The adt CLI is then launched with that absolute path, so: * PATH contents can no longer influence which binary is executed (resolves the Sonar S4036 hotspot). * bun-workspace monorepos still work — the helper walks up exactly as npm/bunx would, finding the hoisted binary at the workspace root (keeps Devin's original review fix). * Windows `.cmd` shims are still handled via `shell: true` gated to win32 per Node's child_process docs.
by Petr Plenkov