{"prompt":"You are comparing an AI-suggested code fix with actual changes made in a commit.\n\nYour task: Determine if the commit contains the essence of the AI fix and provide a confidence level.\n\n## AI-Suggested Fix\n\n**What it fixes:** @tanstack/vue-router:test:types, @tanstack/react-router:test:unit, @tanstack/solid-router:test:unit, @tanstack/vue-router:test:unit, tanstack-react-start-e2e-rsc:test:e2e--rsbuild-ssr--shard-6-of-6\n\n**Description:** fix(router-core): allow stripSearchParams defaults for required fields\n\n**Reasoning:** The PR intentionally changed the search middleware type parameter in `route.ts` from `ResolveFullSearchSchemaInput` to `ResolveFullSearchSchema` (output type). This is correct — middleware runs after validation, so it receives the validated output.\n\nHowever, `stripSearchParams` was typed to only accept defaults for *optional* properties via `PickOptional`. With the input type, a Zod field like `z.string().default('default')` was optional (`string | undefined`), so `PickOptional` i\n\n**Suggested Changes (diff):**\n```diff\ndiff --git a/packages/react-router/tests/link.test.tsx b/packages/react-router/tests/link.test.tsx\nindex f06a3a8d..ec74e6f1 100644\n--- a/packages/react-router/tests/link.test.tsx\n+++ b/packages/react-router/tests/link.test.tsx\n@@ -5891,7 +5891,6 @@ describe('search middleware', () => {\n }),\n search: {\n middlewares: [\n- // this means we cannot get the correct input type for this schema\n stripSearchParams({ foo: 'default' }),\n retainSearchParams(true),\n ],\ndiff --git a/packages/router-core/src/searchMiddleware.ts b/packages/router-core/src/searchMiddleware.ts\nindex a564650a..b8ac1a73 100644\n--- a/packages/router-core/src/searchMiddleware.ts\n+++ b/packages/router-core/src/searchMiddleware.ts\n@@ -82,9 +82,7 @@ function getValidationDefaultKeys(\n export function stripSearchParams<\n TSearchSchema,\n TOptionalProps = PickOptional>,\n- const TValues =\n- | Partial>\n- | Array,\n+ const TValues = Partial> | Array,\n const TInput = IsRequiredParams extends never\n ? TValues | true\n : TValues,\ndiff --git a/packages/solid-router/tests/link.test.tsx b/packages/solid-router/tests/link.test.tsx\nindex d0fc7ae4..03f71805 100644\n--- a/packages/solid-router/tests/link.test.tsx\n+++ b/packages/solid-router/tests/link.test.tsx\n@@ -5762,7 +5762,6 @@ describe('search middleware', () => {\n }),\n search: {\n middlewares: [\n- // this means we cannot get the correct input type for this schema\n stripSearchParams({ foo: 'default' }),\n retainSearchParams(true),\n ],\ndiff --git a/packages/vue-router/tests/link.test.tsx b/packages/vue-router/tests/link.test.tsx\nindex e047fe59..ed223135 100644\n--- a/packages/vue-router/tests/link.test.tsx\n+++ b/packages/vue-router/tests/link.test.tsx\n@@ -5933,7 +5933,6 @@ describe('search middleware', () => {\n }),\n search: {\n middlewares: [\n- // this means we cannot get the correct input type for this schema\n stripSearchParams({ foo: 'default' }),\n retainSearchParams(true),\n ],\n\n```\n\n## Actual Commit Changes\n\n**Commit Diff:**\n```diff\ndiff --git a/packages/router-core/src/searchMiddleware.ts b/packages/router-core/src/searchMiddleware.ts\nindex 1d60cc9587..212b41210f 100644\n--- a/packages/router-core/src/searchMiddleware.ts\n+++ b/packages/router-core/src/searchMiddleware.ts\n@@ -45,9 +45,7 @@ export function retainSearchParams(\n export function stripSearchParams<\n TSearchSchema,\n TOptionalProps = PickOptional>,\n- const TValues =\n- | Partial>\n- | Array,\n+ const TValues = Partial> | Array,\n const TInput = IsRequiredParams extends never\n ? TValues | true\n : TValues,\ndiff --git a/packages/router-core/tests/searchMiddleware.test-d.ts b/packages/router-core/tests/searchMiddleware.test-d.ts\nindex 30729b32b2..8f68d91b21 100644\n--- a/packages/router-core/tests/searchMiddleware.test-d.ts\n+++ b/packages/router-core/tests/searchMiddleware.test-d.ts\n@@ -1,5 +1,10 @@\n import { describe, expectTypeOf, test } from 'vitest'\n-import { BaseRootRoute, BaseRoute, type ValidatorAdapter } from '../src'\n+import {\n+ BaseRootRoute,\n+ BaseRoute,\n+ stripSearchParams,\n+ type ValidatorAdapter,\n+} from '../src'\n \n describe('search middlewares', () => {\n test('should use search validator output for middleware context', () => {\n@@ -36,4 +41,36 @@ describe('search middlewares', () => {\n },\n })\n })\n+\n+ test('should allow stripping default-valued validator output keys', () => {\n+ type RootSearch = {\n+ root?: string\n+ }\n+\n+ type SearchInput = {\n+ foo?: string\n+ }\n+\n+ type SearchOutput = {\n+ foo: string\n+ }\n+\n+ const searchValidator: ValidatorAdapter = {\n+ types: undefined as never,\n+ parse: () => ({ foo: 'default' }),\n+ }\n+\n+ const rootRoute = new BaseRootRoute({\n+ validateSearch: (search: RootSearch): RootSearch => search,\n+ })\n+\n+ new BaseRoute({\n+ getParentRoute: () => rootRoute,\n+ path: '/posts',\n+ validateSearch: searchValidator,\n+ search: {\n+ middlewares: [stripSearchParams({ foo: 'default' })],\n+ },\n+ })\n+ })\n })\n\n```\n\n## Instructions\n\nRate how similar the commit is to the AI fix on a scale of 0-10.\n\n**Scoring Guide:**\n- 10: Nearly identical changes (same files, same logic, same fixes)\n- 8-9: Very similar (same core changes, minor differences in implementation)\n- 6-7: Similar intent (addresses same issue, somewhat different approach)\n- 4-5: Some overlap (touches same area, but different changes)\n- 2-3: Minimal similarity (different files or completely different changes)\n- 0-1: No similarity (unrelated changes)\n\n**Criteria:**\n- Focus on: same files modified, similar logic changes, same bug being fixed\n- The commit may have additional changes beyond the AI fix - that's okay\n- Small differences in implementation are okay if the intent is the same\n\nProvide your score (0-10) and a brief reasoning (2-3 sentences) explaining your assessment.","response":"{\"score\":7,\"reasoning\":\"The commit contains the core fix from the AI suggestion - the critical change to `stripSearchParams` type parameter in `packages/router-core/src/searchMiddleware.ts` is identical, changing `TValues` from `Partial> | Array` to `Partial> | Array`. However, the commit differs significantly in scope: it removes the test file comment changes from the AI fix (in react-router, solid-router, and vue-router test files) and instead adds a new type test in `searchMiddleware.test-d.ts` to validate the fix works correctly. The essential bug fix is present and correct, but the implementation approach for validation differs from the AI suggestion.\"}","model":"claude-haiku-4-5-20251001","cipeFixId":"6a231ab4697dd0d9be9048c3","headSha":"84e83ce6563e5f12124f0f7b241dea722bf4ba21","timestamp":1780689045118}