analog
Failed after BSBen Snyder
View latest

fix(vite-plugin-angular): preserve server mode in environment builds

25203e0d047Open on GitHub

Self-Healing CI

Classification: Environment state

We classified the analog-app-e2e:e2e failure as a pre-existing environment issue rather than a regression introduced by this PR. The PR author explicitly notes that the identical ssr: false route-policy assertion fails on untouched alpha (4225f45090a4), and a dedicated fix is already tracked in analogjs/analog#2523. No changes to this PR are needed to address it.

An empty commit was applied to the branch to trigger a new CI pipeline execution to resolve the environment issue.

The failing task analog-app-e2e:e2e was classified as environment_state rather than code_change for the following reasons:

  1. Not introduced by this PR: The touched_projects list is empty — the analog-app-e2e project was not modified by this PR. The PR's scope is exclusively vite-plugin-angular.

  2. Explicitly acknowledged as a pre-existing defect: The PR author states in the PR body: "After the bootstrap repair, main CI reaches E2E and is blocked by the existing ssr: false route-policy defect. The identical raw-response assertion fails on untouched alpha." This confirms the failure exists on the base branch (alpha at 4225f45090a4) without any of this PR's changes applied.

  3. Deterministic, not flaky: The test failed on all 3 retries with identical output. While the task has a historical flakiness rate of ~6.67%, this failure is reproducible and consistent, pointing to a real underlying bug rather than a timing issue.

  4. A separate PR is already tracking the fix: The PR body references analogjs/analog#2523 (under platform issue analogjs/analog#2522) as the prerequisite fix for this ssr: false route-policy defect. It is being repaired independently.

  5. Root cause is unrelated to the PR changes: The test asserts that server-rendered HTML for the /client (no-SSR) route must not contain analog-client in a JSON-LD script tag. The JSON-LD injector in the platform is incorrectly including SSR output for client-only routes — a pre-existing platform bug unrelated to the compiler lifecycle and Vite compatibility fixes in this PR.