Failed after Ggithub-actions[bot]
View latest

ci: Version Packages (#8486)

7776316aa6aOpen on GitHub

Self-Healing CI

Classification: Flaky task

We looked into the failing stream e2e test and don't believe it's caused by this PR. The changed code only touches route/param matching logic, while the failure is a 30s timeout waiting for the streamed Await/Suspense data to resolve — a subsystem this PR doesn't modify. Given the non-zero historical flakiness rate for this task and no reproduction of the same failure on the reference branch, we're treating this as a flaky test rather than a code issue.

An empty commit was automatically applied to the branch to trigger a new CI pipeline execution to resolve the flaky task.

The failing task is tanstack-solid-start-e2e-serialization-adapters:test:e2e, and specifically only the stream test case timed out (30000ms) waiting for getByTestId('stream-car-expected'). The other 4 tests in the same run (data-only, nested, custom error, nested) all passed.

Tracing the failure:

  • The stream route (e2e/solid-start/serialization-adapters/src/routes/ssr/stream.tsx) renders its content inside a Solid <Suspense>/<Await> boundary that resolves a dataPromise created with a 1-second setTimeout.
  • The <Await>/useAwaited implementation (packages/solid-router/src/awaited.tsx) is built entirely on defer() from packages/router-core/src/defer.ts and Solid's createResource — it has no dependency on route matching, params, or the match array.
  • The PR's actual diff is scoped to packages/router-core/src/new-process-route-tree.ts and packages/router-core/src/router.ts, both of which only change how path segments/params are matched and extracted (findRouteMatch, extractParams, matchRoutes/getMatchedRoutes param plumbing, useMatchRoute). None of the touched files are in the deferred-promise/streaming/serialization code path (defer.ts, load-server.ts, load-client.ts, ssr/*) that the stream test actually exercises.
  • The webserver log for the failing run shows the /ssr/stream page and its JS/CSS assets all returned 200 with normal latency — there's no error, exception, or indication that route matching failed. The page loaded and hydrated correctly (confirmed by awaitPageLoaded succeeding beforehand); only the later data-resolution step hung.
  • The similar-task-failure-detector subagent found no record of this same task/error on the reference branch (8269), so this isn't a known pre-existing break there, but that alone doesn't prove causation given the code-path analysis above.
  • mcp__utilities__task_flakiness_rates reports a non-zero flakiness rate (~2.9%) for this exact task, and the touched_projects list for this PR is empty — the e2e project itself was not directly modified.
  • Combining an unmodified, unrelated code path (streaming/defer) with a timeout-style failure and a documented non-zero flakiness rate for this task points to an intermittent/timing issue in the test rather than a regression introduced by the route-matching changes in this PR.

No code changes are proposed at this step; the recommendation is to rerun the task, since a rerun can immediately resolve a flaky failure like this.