Failed
Open on GitHub

perf(react-router): derive Link subscriptions from destination dependencies

SSheraff
bba47e21
8553Latest execution

Self-Healing CI

Classification: Flaky task

We believe this failure is a flaky task rather than something caused by this PR. Only one of five tests in the suite failed (a streamed SSR data timeout), while the other four — including ones that exercise the same solid-router loading/status state — passed, and this task already has an 11% baseline flakiness rate. None of the PR's changes (React Link derivation, router-core's buildLocation, history, and the workspace-only Store patch) touch solid-start, solid-router, or the streaming/serialization code exercised by the failing test.

An empty commit was automatically applied to the branch to trigger a new CI pipeline execution to resolve the flaky task.

The failing task, tanstack-solid-start-e2e-serialization-adapters:test:e2e, is not classified as a code change for the following reasons:

  1. Isolated failure within the suite Only 1 of 5 tests failed: "SSR serialization adapters > stream", which timed out after 30s waiting for a stream-car-expected locator to appear (i.e., deferred/streamed SSR data never rendered in time). The other four tests passed, including tests that depend on the same shared awaitPageLoaded helper, which asserts on solid-router's router-isLoading / router-status state — state that is driven directly by the router-core class this PR modifies. If the PR's router-core changes had broken core loading/matching behavior, it would be expected to affect more than just this one streaming test.

  2. No overlap between the diff and the failing project's code paths The PR's substantive changes are scoped to:

    • @tanstack/react-router's link.tsx (converting useSelector to a useSyncExternalStore-based subscription)
    • @tanstack/history (exporting _normalizeHref, refactoring createHref assignment)
    • @tanstack/router-core (adding an optional lazy getLocation argument to buildLocation)
    • A temporary pnpm patch to @tanstack/store's computed-atom lifetime handling

    None of these touch solid-start, solid-router's own Link implementation, or any server-function streaming/serialization code. The patched @tanstack/store package is only referenced as a devDependency inside router-core's own test utilities, not pulled into the solid-start/solid-router runtime dependency graph.

  3. Failure signature is consistent with known flakiness The failure is a generic async timeout waiting on streamed SSR content — a well-known source of nondeterminism in end-to-end streaming tests — and this task already carries a non-zero baseline flakiness rate (11%). Combined with the absence of any diff hunk that plausibly explains this specific failure mode, this points toward pre-existing flakiness rather than a regression introduced by this PR.

Taken together, the evidence favors flaky_task over code_change, so no source changes are proposed at this step.