Overview - Typescript-eslint

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
main
204eabc2 fix(eslint-plugin): [consistent-indexed-object-style] do not remove comments when fixing (#12396) * fix(eslint-plugin): [consistent-indexed-object-style] do not remove comments when fixing The autofix rebuilds the type from the text of a couple of sub-nodes (the key/value types or the mapped type constraint/value). Any comments that sat between those sub-nodes were silently dropped, so applying the fix could delete code. Withhold the fix (and the index-signature suggestion) whenever the node being replaced contains comments, mirroring how the rule already skips fixing when it cannot safely produce equivalent output. Fixes #10577 * fix(eslint-plugin): [consistent-indexed-object-style] suggest reshape instead of dropping the fix on comments Narrow the comment check so only comments the fixer would actually drop - those inside the reported node but outside every sub-node whose text the fix reuses - block the autofix. Comments that live inside a preserved sub-node ride along and keep autofixing as before. For the genuinely-lossy case, offer the reshape as a suggestion rather than withholding it entirely, so converting the type stays available as an explicit opt-in action instead of silently discarding the comment. The `-readonly` mapped type stays untouched since there is no builtin Mutable<T> to express it. * Update packages/eslint-plugin/tests/rules/consistent-indexed-object-style.test.ts --------- Co-authored-by: Kirk Waiblinger <53019676+kirkwaiblinger@users.noreply.github.com>
by Sarath Fra...
Succeeded
fix/consistent-indexed-object-style-preserve-comments
a0fd20cf Merge f3a9ea24f5a2acdc0c1be09f142c1d39d24dde5e into 4ba3e02e46a3d01c24b030771ec6fc8d52385c61
by Sarath Fra...
Succeeded
fix/consistent-indexed-object-style-preserve-comments
9d1ed336 Merge ce6eaa90bd5c08d6dc5879a8a3ad0ab08a1697b5 into ef1fd28c68b10da2e5b56823da8491f10f2c2b97
by Sarath Fra...
Succeeded
fix/consistent-indexed-object-style-preserve-comments
9948a452 Merge d7be4a3f5491ef51ac332ccb708c204a302e72f9 into 4f84a697aedc436559c3ae09b5b357d98b448d68
by Sarath Fra...