Overview - Router

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
7955
5c400bc3 chore(e2e): migrate selective-ssr pending-min route to Solid 2 onSettled onMount is gone in Solid 2 — record the pending/target mount events via onSettled instead. Also picks up routeTree.gen.ts regeneration churn. Verified with the selective-ssr e2e suite (11/11 passing). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
by Brenley Dueck
Succeeded
solid-router-v2-pre-main-merge-2
a7ed1ff6 fix(solid-start): resolve SSR'd lazy() client assets via vite-plugin-solid's manifest Solid 2's streaming renderer resolves the modules behind server-rendered lazy() boundaries through its `manifest` render option: it emits stylesheet links and modulepreloads for the lazy chunk and serializes the module→asset map the client needs to preload it before hydration. TanStack Start never provided that manifest — its own start manifest is route-keyed and intentionally excludes dynamic-import chunks — so direct visits to routes with SSR'd lazy() components rendered without the lazy chunk's CSS and logged "Asset manifest returned no client assets" on every request. (Pre-merge this was masked: the old Match tree re-rendered the boundary client-side after the failed hydration, fetching the CSS late via Vite's dynamic-import helper.) Wire up vite-plugin-solid's `virtual:solid-manifest` (dev module-graph resolver in dev, the client build's `.vite/manifest.json` in builds), kept entirely inside the solid packages: - solid-router ships an inert `ssr/clientAssetsManifest` stub that the renderers prefer over the route-keyed manifest when non-undefined - solid-start's vite plugin swaps the stub for `virtual:solid-manifest` in the server environment (with `isEntry` neutralized so Solid doesn't duplicate the entry stylesheet Start already emits) and enables `build.manifest` for the client build - bundlers without the plugin (rsbuild) keep the stub and current behavior Fixes the two shared-widget lazy-CSS tests in the solid-start start-manifest e2e (10/10 passing; selective-ssr and basic suites verified unaffected). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
by Brenley Dueck
Failed
7955
e021c7a3 fix(solid-router): keep Transitioner hydration ids in sync between server and client Solid 2 derives hydration keys from the reactive owner tree, and its server onSettled stub consumes a child-id slot to mirror the client's effect owner. The server early-return in Transitioner skipped that registration, shifting every subsequent hydration key by one and causing a root-level hydration mismatch that discarded the server-rendered HTML (breaking deferred/streaming content and redirects in the solid-start e2e suites). Run the same code on both sides again: the onSettled callback never executes on the server, so only the owner-tree structure is shared. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
by Brenley Dueck
Failed
7955
e958330a Merge branch 'main' into solid-router-v2-pre-main-merge-2 # Conflicts: # benchmarks/client-nav/package.json # e2e/solid-start/basic-auth/package.json # e2e/solid-start/basic-solid-query/package.json # e2e/solid-start/basic-tsr-config/package.json # e2e/solid-start/csp/package.json # e2e/solid-start/query-integration/package.json # e2e/solid-start/query-integration/src/routeTree.gen.ts # e2e/solid-start/scroll-restoration/package.json # e2e/solid-start/serialization-adapters/package.json # e2e/solid-start/server-functions/package.json # e2e/solid-start/server-routes/package.json # e2e/solid-start/virtual-routes/package.json # e2e/solid-start/website/package.json # examples/react/start-rscs/package.json # examples/solid/authenticated-routes-firebase/package.json # examples/solid/authenticated-routes/package.json # examples/solid/basic-default-search-params/package.json # examples/solid/basic-devtools-panel/package.json # examples/solid/basic-file-based/package.json # examples/solid/basic-non-nested-devtools/package.json # examples/solid/basic-solid-query-file-based/package.json # examples/solid/basic-solid-query/package.json # examples/solid/basic-ssr-file-based/package.json # examples/solid/basic-ssr-streaming-file-based/package.json # examples/solid/basic-virtual-file-based/package.json # examples/solid/basic-virtual-inside-file-based/package.json # examples/solid/basic/package.json # examples/solid/deferred-data/package.json # examples/solid/i18n-paraglide/package.json # examples/solid/kitchen-sink-file-based/package.json # examples/solid/kitchen-sink-solid-query-file-based/package.json # examples/solid/kitchen-sink-solid-query/package.json # examples/solid/kitchen-sink/package.json # examples/solid/large-file-based/package.json # examples/solid/location-masking/package.json # examples/solid/navigation-blocking/package.json # examples/solid/quickstart-esbuild-file-based/package.json # examples/solid/quickstart-file-based/package.json # examples/solid/quickstart-rspack-file-based/package.json # examples/solid/quickstart-webpack-file-based/package.json # examples/solid/quickstart/package.json # examples/solid/router-monorepo-simple-lazy/package.json # examples/solid/router-monorepo-simple-lazy/packages/app/package.json # examples/solid/router-monorepo-simple-lazy/packages/post-feature/package.json # examples/solid/router-monorepo-simple-lazy/packages/router/package.json # examples/solid/router-monorepo-simple/package.json # examples/solid/router-monorepo-simple/packages/app/package.json # examples/solid/router-monorepo-simple/packages/post-feature/package.json # examples/solid/router-monorepo-simple/packages/router/package.json # examples/solid/router-monorepo-solid-query/package.json # examples/solid/router-monorepo-solid-query/packages/app/package.json # examples/solid/router-monorepo-solid-query/packages/post-feature/package.json # examples/solid/router-monorepo-solid-query/packages/post-query/package.json # examples/solid/router-monorepo-solid-query/packages/router/package.json # examples/solid/scroll-restoration/package.json # examples/solid/search-validator-adapters/package.json # examples/solid/start-basic-auth/package.json # examples/solid/start-basic-authjs/package.json # examples/solid/start-basic-cloudflare/package.json # examples/solid/start-basic-netlify/package.json # examples/solid/start-basic-nitro/package.json # examples/solid/start-basic-solid-query/package.json # examples/solid/start-basic-static/package.json # examples/solid/start-basic/package.json # examples/solid/start-bun/package.json # examples/solid/start-convex-better-auth/package.json # examples/solid/start-counter/package.json # examples/solid/start-i18n-paraglide/package.json # examples/solid/start-large/package.json # examples/solid/start-streaming-data-from-server-functions/package.json # examples/solid/start-supabase-basic/package.json # examples/solid/start-tailwind-v4/package.json # examples/solid/view-transitions/package.json # examples/solid/with-framer-motion/package.json # examples/solid/with-trpc/package.json # packages/router-devtools-core/package.json # packages/solid-router-devtools/CHANGELOG.md # packages/solid-router-devtools/package.json # packages/solid-router/CHANGELOG.md # packages/solid-router/package.json # packages/solid-router/src/CatchBoundary.tsx # packages/solid-router/src/Match.tsx # packages/solid-router/src/Matches.tsx # packages/solid-router/src/Scripts.tsx # packages/solid-router/src/Transitioner.tsx # packages/solid-router/src/headContentUtils.tsx # packages/solid-router/src/lazyRouteComponent.tsx # packages/solid-router/src/link.tsx # packages/solid-router/src/routerStores.ts # packages/solid-router/src/ssr/RouterClient.tsx # packages/solid-router/src/useMatch.tsx # packages/solid-router/tests/link.test.tsx # packages/solid-router/tests/loaders.test.tsx # packages/solid-router/tests/routeContext.test.tsx # packages/solid-router/tests/store-updates-during-navigation.test.tsx # packages/solid-start-client/CHANGELOG.md # packages/solid-start-client/package.json # packages/solid-start-server/CHANGELOG.md # packages/solid-start-server/package.json # packages/solid-start/CHANGELOG.md # packages/solid-start/package.json # pnpm-lock.yaml
by Brenley Dueck