Overview - Ghost

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
main
a2ae126f Format files for v6.60.0's new oxfmt enforcement v6.60.0 introduces oxfmt as a required format:check CI step. Reformat the fork-only email adapter files (never touched by upstream's own reformatting sweep) plus the two files touched by this merge's conflict resolution. Also reformats .changeset/ledger.yaml and ghost/core/package.json, which already failed format:check on main before this merge (pre-existing, unrelated drift) but block the same CI step on this branch either way.
by Claude
Succeeded
main
e40ebc25 Merge pull request #23 from madewithlove/chore/sync-v6.60.0 Sync with upstream Ghost v6.60.0
by Andreas Cr...
Succeeded
30317
c63173f5 Added public api surfaces to the admin domains no ref The admin shell (routes.tsx), the layout, and several domains deep-imported other domains' internals, so every screen move risked breaking unrelated folders. Each domain (members, tags, comments, automations, posts, onboarding, whats-new, settings) now exposes an api.ts mirroring analytics/api.ts, and the shell, layout, and cross-domain consumers import only those surfaces. Route definitions the shell held inline (members children, the posts analytics subtree) moved into their domains; lazy entries stay dynamic imports inside the domains so route-level code-splitting is unchanged (production build emits an identical chunk inventory). Cross-domain strays were re-homed: buildMembersUrl, the member formatting helpers, and the shared-views parsing now flow through members/api.ts; the whats-new dialog, banner, and hooks through whats-new/api.ts; BrandIcon and its svg set moved from settings to src/shared/brand-icon; the AccessRule types moved to src/route-access.ts and NotFound to src/shared so domains no longer import shell files. Two dependency-cruiser rules keep it that way: domains may import a different domain only via its api.ts, and the shell and layout may import domains only via api.ts. Both rules were proven to fire on deliberate violations in the unresolved @/-specifier and resolved relative shapes, then the violations were reverted.
by Steve Larson
Succeeded
23
d341805b Remove unnecessary .jshintrc
by Jacob Gable
Succeeded
30318
576c9dc5 Moved application styles out of the Shade stylesheet no ref Shade's stylesheet carried admin-app concerns that every consumer paid for. The 21 fonts.bunny.net imports serving the settings font pickers loaded on every admin page; they now live in an admin-owned settings/custom-fonts.css imported by the two picker screens, so the fetches ship with the lazily loaded settings chunk instead of the entry CSS (entry drops from 319,977 to 318,348 bytes and no longer touches bunny.net). The font-* utilities those pickers use must still be generated in Admin's single Tailwind lane, so the family @theme variables moved to admin's index.css rather than the lazy file; first open of a picker can now show a brief FOUT while the families fetch. The .gh-prose-links and dark-mode .gh-loading-orb rules and the members-sticky-hover-bg variable were admin-only: the rules moved to admin's index.css, and the variable — an alias of table-row-hover in both themes — was replaced at its single consumer with the table-row-hover token. The unused setting-highlight-fade-out animation token was removed outright. The .dark .shade base color swapped its #fafafb literal for the foreground token. Before/after screenshots show no visible change: every dark-mode surface already sets explicit color tokens, and the inherited fallback now matches text-primary instead of sitting slightly brighter than it.
by Steve Larson
Succeeded
main
aff61d4b Refactor gift purchase form (#30278) ref https://linear.app/ghost/issue/BER-3890 The personalised gift purchase form has grown out of bounds. Splitting it into smaller components and porting to TS in preparation for reworking the state management.
by Jonatan Sv...
Succeeded
988
22437365
by pull[bot]
Succeeded
30316
809a145d Moved UI-only e2e cases to the acceptance tier no ref Tier rule: acceptance asserts both directions of the client's API contract against the in-browser fake server; e2e asserts the server's side and real persistence, one journey per family. UI assertions that need no real server were living in e2e — this ports them down and leaves each family one true journey. Analytics (site) — ported to analytics.acceptance.test.tsx, e2e deleted: - web-traffic.test.ts (6 cases: zeroed graph tabs, empty top content/sources/locations, posts/pages tab empties) -> "renders zeroed KPIs and empty cards when there are no visits" + "keeps the empty state across the top content tabs"; file deleted. - growth.test.ts (4 empty top-content tab cases) -> "shows No conversions across the top content tabs when nothing converted"; file deleted. The fake world zero-fills the member-count history the way the server does — a fully empty history collapses the view. - newsletters.test.ts empty cards (3 cases) -> "shows the empty state on every newsletter card when none were sent"; the total-subscribers percent-change case (real member import + server stats) remains. - overview.test.ts latest-post/top-posts zero cases (2) -> "renders the latest and top posts with zeroed stats when nothing is recorded"; view-more navigations (2) -> "navigates to the web traffic view from the visitors KPI" / "navigates to the growth view from the members KPI". The records-visitor journey (real Tinybird ingest) remains. Post analytics — ported to post-analytics.acceptance.test.tsx: - post-analytics/overview.test.ts (5 cases: tabs render, zeroed growth section, web/growth view-more empties, growth hidden when members_track_sources is off) -> four new acceptance cases (the tracking-off case is a boot override instead of a live settings toggle + reload); file deleted. - post-analytics/growth.test.ts (3 cases: zeroed members card, empty top sources, view-member link) -> "renders the zeroed members card and empty sources..." + "links the members KPI to the members list filtered to this post" (also asserts the outgoing NQL filter); file deleted. web-filters journeys (real traffic) remain. Integrations — integrations.acceptance.test.tsx: - Transistor enable/badge was covered; added the disable direction ("clears the Active badge after disabling") and a Pintura disable save leg; Unsplash both directions were already covered. - The transistor labs flag was removed in #27082, so the e2e visible/hidden-by-flag cases asserted a gate that no longer exists; replaced by "shows the Transistor integration in the built-in list". - e2e keeps one journey: transistor enabled state persists after page reload. Tags — tag-detail.acceptance.test.tsx: - 404 for an unknown slug -> "shows the not-found page when the tag does not exist"; nav active state on /tags/new and while editing -> two "keeps the Tags nav item active..." cases (active state is React-Router-computed, not Ember-bridge). Load-by-slug was already covered by "renders the seeded tag". - e2e keeps the true journeys: add, edit, no-duplicate edit, delete with and without posts. - sidebarScreen.navLink now scopes to the shell sidebar testid: the tag-detail breadcrumb repeats the "Tags" link name and broke strict locator mode. Registry adoption: the e2e settings section/staff/member-details page objects now import their testids from @tryghost/test-data selectors instead of hard-coding them; missing constants added additively (settings: integrations, dangerzone, site-visibility-select, owner-user, custom-field-list-item, free-welcome-email-row, header-image-field, welcome-email-editor, profile/cover image upload+preview, publication-cover, and the Shade image-upload container/delete ids; members: member-actions, member-detail-title/-engagement, member-subscription-toggle, member-signin-url, confirm/cancel-delete). Registries share strings only; locator code stays in each tier.
by Steve Larson
Succeeded
30317
c63173f5 Added public api surfaces to the admin domains no ref The admin shell (routes.tsx), the layout, and several domains deep-imported other domains' internals, so every screen move risked breaking unrelated folders. Each domain (members, tags, comments, automations, posts, onboarding, whats-new, settings) now exposes an api.ts mirroring analytics/api.ts, and the shell, layout, and cross-domain consumers import only those surfaces. Route definitions the shell held inline (members children, the posts analytics subtree) moved into their domains; lazy entries stay dynamic imports inside the domains so route-level code-splitting is unchanged (production build emits an identical chunk inventory). Cross-domain strays were re-homed: buildMembersUrl, the member formatting helpers, and the shared-views parsing now flow through members/api.ts; the whats-new dialog, banner, and hooks through whats-new/api.ts; BrandIcon and its svg set moved from settings to src/shared/brand-icon; the AccessRule types moved to src/route-access.ts and NotFound to src/shared so domains no longer import shell files. Two dependency-cruiser rules keep it that way: domains may import a different domain only via its api.ts, and the shell and layout may import domains only via api.ts. Both rules were proven to fire on deliberate violations in the unresolved @/-specifier and resolved relative shapes, then the violations were reverted.
by Steve Larson
Failed
30286
463401c8 Fixed analytics freshness regressions from the Tinybird swap no ref Review follow-up. The swap inherited the app-wide refetchOnWindowFocus: false, but the old charts-lib SWR layer revalidated on focus - an analytics dashboard left open went stale until navigation. Pipe queries now refetch stale data on window focus. Active-visitors polling also stopped in hidden tabs (v5's refetchIntervalInBackground default); it now keeps polling like the old interval tick did. Both covered by new unit cases.
by Steve Larson
Failed
23
d341805b Remove unnecessary .jshintrc
by Jacob Gable
Failed
main
aff61d4b Refactor gift purchase form (#30278) ref https://linear.app/ghost/issue/BER-3890 The personalised gift purchase form has grown out of bounds. Splitting it into smaller components and porting to TS in preparation for reworking the state management.
by Jonatan Sv...
Succeeded
30316
809a145d Moved UI-only e2e cases to the acceptance tier no ref Tier rule: acceptance asserts both directions of the client's API contract against the in-browser fake server; e2e asserts the server's side and real persistence, one journey per family. UI assertions that need no real server were living in e2e — this ports them down and leaves each family one true journey. Analytics (site) — ported to analytics.acceptance.test.tsx, e2e deleted: - web-traffic.test.ts (6 cases: zeroed graph tabs, empty top content/sources/locations, posts/pages tab empties) -> "renders zeroed KPIs and empty cards when there are no visits" + "keeps the empty state across the top content tabs"; file deleted. - growth.test.ts (4 empty top-content tab cases) -> "shows No conversions across the top content tabs when nothing converted"; file deleted. The fake world zero-fills the member-count history the way the server does — a fully empty history collapses the view. - newsletters.test.ts empty cards (3 cases) -> "shows the empty state on every newsletter card when none were sent"; the total-subscribers percent-change case (real member import + server stats) remains. - overview.test.ts latest-post/top-posts zero cases (2) -> "renders the latest and top posts with zeroed stats when nothing is recorded"; view-more navigations (2) -> "navigates to the web traffic view from the visitors KPI" / "navigates to the growth view from the members KPI". The records-visitor journey (real Tinybird ingest) remains. Post analytics — ported to post-analytics.acceptance.test.tsx: - post-analytics/overview.test.ts (5 cases: tabs render, zeroed growth section, web/growth view-more empties, growth hidden when members_track_sources is off) -> four new acceptance cases (the tracking-off case is a boot override instead of a live settings toggle + reload); file deleted. - post-analytics/growth.test.ts (3 cases: zeroed members card, empty top sources, view-member link) -> "renders the zeroed members card and empty sources..." + "links the members KPI to the members list filtered to this post" (also asserts the outgoing NQL filter); file deleted. web-filters journeys (real traffic) remain. Integrations — integrations.acceptance.test.tsx: - Transistor enable/badge was covered; added the disable direction ("clears the Active badge after disabling") and a Pintura disable save leg; Unsplash both directions were already covered. - The transistor labs flag was removed in #27082, so the e2e visible/hidden-by-flag cases asserted a gate that no longer exists; replaced by "shows the Transistor integration in the built-in list". - e2e keeps one journey: transistor enabled state persists after page reload. Tags — tag-detail.acceptance.test.tsx: - 404 for an unknown slug -> "shows the not-found page when the tag does not exist"; nav active state on /tags/new and while editing -> two "keeps the Tags nav item active..." cases (active state is React-Router-computed, not Ember-bridge). Load-by-slug was already covered by "renders the seeded tag". - e2e keeps the true journeys: add, edit, no-duplicate edit, delete with and without posts. - sidebarScreen.navLink now scopes to the shell sidebar testid: the tag-detail breadcrumb repeats the "Tags" link name and broke strict locator mode. Registry adoption: the e2e settings section/staff/member-details page objects now import their testids from @tryghost/test-data selectors instead of hard-coding them; missing constants added additively (settings: integrations, dangerzone, site-visibility-select, owner-user, custom-field-list-item, free-welcome-email-row, header-image-field, welcome-email-editor, profile/cover image upload+preview, publication-cover, and the Shade image-upload container/delete ids; members: member-actions, member-detail-title/-engagement, member-subscription-toggle, member-signin-url, confirm/cancel-delete). Registries share strings only; locator code stays in each tier.
by Steve Larson
Succeeded
30279
c47d39d7 Fixed gift form state across Stripe checkout fixes https://linear.app/ghost/issue/BER-3890 Persisted the personalised gift checkout draft in session storage so returning from Stripe restores the delivery step without losing buyer or recipient input. Explicit plan and delivery routes preserve browser navigation for direct and in-Portal entry points, while shared abandonment actions and a valid checkout success clear saved personal data. Session storage failures continue with in-memory state, and the implementation remains Portal-only on the existing gift checkout API contract.
by Jonatan Sv...
Failed
30310
0e26f949 Changed the Stripe fixture check to typecheck the scripts it runs The scripts that capture fixtures from Stripe and probe what it accepts import the request builder out of ghost/core, so that they send what Ghost sends. Nothing typechecked them, and they had already rotted against a change to that builder without anything noticing. The e2e package now declares the dependency it typechecks against, so the build that runs before the fixture check pulls it in, and the check itself runs through nx rather than as steps written into one workflow. A rule about how a package is built belongs in the package rather than in the one place that happens to build it. Rewriting the capture script leaves the checkout session it used to record behind, unread by anything, so it goes too. ref https://linear.app/ghost/issue/BER-3872
by Rob Lester
Failed
30309
187c2a0c Added Stripe checkout collection into member custom fields A tier could say what its checkout should collect and where each answer belongs, and nothing acted on it. This connects the two ends: the session Ghost creates now asks for what the tier configured, and the completed session's answers are written into the member's fields. What comes back is read as ports and values, so nothing outside the bindings knows a field key, and each value is written in its own transaction — atomic across the parts of an address, but no wider, because a postcode a processor formatted differently must not cost the phone number beside it. None of it may fail the webhook, which is busy creating the member and linking the subscription. The limits a checkout page enforces were measured against the live API rather than read from the reference, which disagreed with it in three of five probes. One of those measurements matters on its own: Stripe will not collect a tax number for a customer it may not rename, so a tier that asked for one could not be bought by a member who already had a Stripe customer. A site that has configured nothing sends a request identical to the one it sent before, and the whole path stays behind the members custom fields flag. ref https://linear.app/ghost/issue/BER-3872
by Rob Lester
Failed
main
9a33b01b Added checkout collection to the fake Stripe server (#30304) Stripe Checkout can be asked to collect a shipping address, a phone number or a tax number alongside the payment, and the fake server the end-to-end tests run against knew none of it. Anything built on top would have been tested against a server that accepted whatever it was sent, which is the opposite of what a fake is for. The rules it now enforces were measured against the live API at the version Ghost pins rather than read from the reference, which disagreed with the API in three of five probes, so a request the real Stripe would refuse now fails a test here first, including the one refusal that is easy to miss: a tax number cannot be collected for a customer Stripe may not rename. Modelling those rules turned up one of its own. Stripe's SDK form-encodes its request bodies, so a checkout that switched tax collection off arrives carrying the string "false" rather than the boolean, and reading that flag for truthiness refused a checkout that had asked for no tax number at all. The existing tests missed it because they post JSON, where the flag is a real boolean, so the refusal only appeared under the encoding Ghost actually uses. A captured fixture also carried the real street and postcode of a payment made while capturing it, and carries invented ones instead now that nothing asserts on their contents. ref https://linear.app/ghost/issue/BER-3872 Claude-Session: https://claude.ai/code/session_018jPEJMYLoUzNvYbdxWb3dY
by Rob Lester
Failed
30306
5cdcf036 Added a tier's checkout configuration and the bindings it writes through A publisher can now say what a tier's checkout asks for beyond the payment, and where each answer is kept. The answer to where is a binding: it names the source that collects, the source's own word for the thing, and the field the value lands in. Everything that writes into a member's custom fields goes through one, so what writes into a field is a single join rather than a different one per writer. Where a value lands and whether it is being collected are one row, because holding them apart in two tables let them disagree, with no composite foreign key or check constraint able to stop it: a tier could ask for something with nowhere to put it, or go on receiving what a publisher had turned off. A binding outlives the collection it carries, so turning collection off keeps the record of where the value went and turning it on again finds the same field rather than making a second one beside it. Turning collection on always succeeds. A publisher who names a field gets that field; one who names none gets whatever this tier already used, or whatever another tier settled on, or a field made for them. Nothing sends any of this to a payment processor yet, and every route that changes it is behind the members custom fields flag. ref https://linear.app/ghost/issue/BER-3872
by Rob Lester
Succeeded
30305
f25890d2 Changed the import's writer port to take the shared writer type The composition root restated the writer's shape inline rather than naming the type the values service exports, and a port that restates a shape it builds a value against is a place for the two to drift apart quietly: method parameters are bivariant, so a writer that grew a field would still satisfy the port and the mismatch would surface nowhere. The plan stays opaque, because the import only ferries one; the writer does not, because the import constructs it. Claude-Session: https://claude.ai/code/session_018jPEJMYLoUzNvYbdxWb3dY
by Rob Lester
Succeeded
main
a2ae126f Pass config to MailgunEmailProvider in the Mailgun adapter MailgunEmailProvider.send() reads this.#config.get('bulkEmail:mailgun:tag'), but the adapter never passed configService through, so every real send (test emails, newsletter sends) threw "Cannot read properties of undefined (reading 'get')". Pre-existing bug, unmasked by e2e tests that exercise the real send path instead of an injected test double.
by Claude