Overview - Ghost

Ghost

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
steve/pla-209-i18n-dual-format
d04bc7d8 Merge 6ce110da739d968300964940ab0bcd79cb7114f9 into 5a7af1e0475eb78db6a173935d599e00879c345a
by Steve Larson
Failed
29144
6ce110da Moved shared registry wiring into the esm-factory ref PLA-209 - the per-namespace browser entries were copy-pasting the glob->registry loop; moved it into esm-factory as i18nFromGlob(globModules, namespace) - each entry is now just the literal glob pattern + namespace name (the only bits Vite requires to be per-file, since import.meta.glob patterns must be literals) plus the standard re-exports — everything else is shared
by Steve Larson
Succeeded
29144
565d8a67 Cleaned up @tryghost/i18n dual-format tooling per review ref PLA-209 - ship the two .d.ts as committed static files (index.d.ts, registry.d.ts) and drop scripts/generate-types.js + the build:types step. The "generator" only ever wrote two constant strings, so it was a build step producing fixed output — the files describe the surface directly now (typechecked clean for consumers) - build/ is no longer produced; removed it from files + nx build outputs. build now just runs build:registry - removed scripts/measure-bundle-locales.js — an ad-hoc bundle-analysis helper that didn't belong in the shipped package - trimmed the vite-public-app.mjs i18n comment to describe the current registry import, without the historical dynamicRequireTargets narrative
by Steve Larson
Succeeded
29144
565d8a67 Cleaned up @tryghost/i18n dual-format tooling per review ref PLA-209 - ship the two .d.ts as committed static files (index.d.ts, registry.d.ts) and drop scripts/generate-types.js + the build:types step. The "generator" only ever wrote two constant strings, so it was a build step producing fixed output — the files describe the surface directly now (typechecked clean for consumers) - build/ is no longer produced; removed it from files + nx build outputs. build now just runs build:registry - removed scripts/measure-bundle-locales.js — an ad-hoc bundle-analysis helper that didn't belong in the shipped package - trimmed the vite-public-app.mjs i18n comment to describe the current registry import, without the historical dynamicRequireTargets narrative
by Steve Larson
Succeeded
29144
18519282 Fixed require leak crashing public apps under the i18n ESM registry path ref PLA-209 - comments-ui and signup-form acceptance tests were failing: both apps never rendered because the built UMD bundle threw "require is not defined" at load - the per-namespace registry path (registry/<ns> -> esm-factory.mjs) imported the CJS lib/i18n-core.js, whose require('i18next') / require('./locale-data.json') leaked verbatim into the browser bundle. This PR had removed the vite commonjsOptions that previously transformed ghost/i18n, so nothing rewrote them - fix keeps the browser graph pure ESM: added lib/i18n-core.mjs (static i18next + JSON imports) as the twin of the CJS lib/i18n-core.js, and pointed esm-factory at it. No package.json "browser" mapping reintroduced - the two cores are deliberate twins (Node needs sync CJS, browser needs pure ESM); guarded by a CJS/ESM parity test. CJS core logic is byte-identical to before, so ghost core's Node path is unchanged - verified: all 4 public apps build with 0 leaked require/module.exports; i18n suite 45 tests / 100% coverage; lint + registry freshness green
by Steve Larson
Failed
29144
3e9429ac Updated app tests to i18n per-namespace subpath imports ref PLA-209. Portal errors.test vi.mock target + test-utils and comments pagination test now import @tryghost/i18n/registry/<ns> to match source.
by Steve Larson
Failed
29144
3e9429ac Updated app tests to i18n per-namespace subpath imports ref PLA-209. Portal errors.test vi.mock target + test-utils and comments pagination test now import @tryghost/i18n/registry/<ns> to match source.
by Steve Larson