Overview - Ghost

Ghost

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
29373
db23b9d6 Fixed the labs test-behaviour comment ref BER-3799 The comment claimed all flags in GA_FEATURES, BETA_FEATURES, and ALPHA_FEATURES are globally enabled during E2E tests, which was wrong on three counts: BETA_FEATURES and ALPHA_FEATURES don't exist (the constants are PUBLIC_BETA_FEATURES and PRIVATE_FEATURES), GA_FEATURES are always true everywhere rather than being a test behaviour, and the mechanism lives in enableAllLabsFeatures in test/utils/fixture-utils.js — not labs.js — which enables every key in WRITABLE_KEYS_ALLOWLIST on each fixture init. The comment now names the real mechanism and file, and spells out the consequence: a response key behind a private flag still moves E2E snapshots even though the flag is off in production.
by Rob Lester
Succeeded
29373
6905787d Fixed the labs test-behaviour comment ref BER-3799 The comment claimed all flags in GA_FEATURES, BETA_FEATURES, and ALPHA_FEATURES are globally enabled during E2E tests, which was wrong on three counts: BETA_FEATURES and ALPHA_FEATURES don't exist (the constants are PUBLIC_BETA_FEATURES and PRIVATE_FEATURES), GA_FEATURES are always true everywhere rather than being a test behaviour, and the mechanism lives in enableAllLabsFeatures in test/utils/fixture-utils.js — not labs.js — which enables every key in WRITABLE_KEYS_ALLOWLIST on each fixture init. The comment now names the real mechanism and file, and spells out the consequence: a response key behind a private flag still moves E2E snapshots even though the flag is off in production.
by Rob Lester
Succeeded
feat/ber-3790-member-custom-field-values
61fc9e44 Merge f1b7e4b0d1f12cbbe7ef5eea02afb406e621a4cf into 88a1a1d46dfebe50b4f5fb5d5fa9b7562c7b2c73
by Rob Lester
Succeeded
29373
f1b7e4b0 Fixed the labs test-behaviour comment ref BER-3799 The comment claimed all flags in GA_FEATURES, BETA_FEATURES, and ALPHA_FEATURES are globally enabled during E2E tests, which was wrong on three counts: BETA_FEATURES and ALPHA_FEATURES don't exist (the constants are PUBLIC_BETA_FEATURES and PRIVATE_FEATURES), GA_FEATURES are always true everywhere rather than being a test behaviour, and the mechanism lives in enableAllLabsFeatures in test/utils/fixture-utils.js — not labs.js — which enables every key in WRITABLE_KEYS_ALLOWLIST on each fixture init. The comment now names the real mechanism and file, and spells out the consequence: a response key behind a private flag still moves E2E snapshots even though the flag is off in production.
by Rob Lester
Failed
29373
8b59c74f Fixed the labs test-behaviour comment ref BER-3799 The comment claimed all flags in GA_FEATURES, BETA_FEATURES, and ALPHA_FEATURES are globally enabled during E2E tests, which was wrong on three counts: BETA_FEATURES and ALPHA_FEATURES don't exist (the constants are PUBLIC_BETA_FEATURES and PRIVATE_FEATURES), GA_FEATURES are always true everywhere rather than being a test behaviour, and the mechanism lives in enableAllLabsFeatures in test/utils/fixture-utils.js — not labs.js — which enables every key in WRITABLE_KEYS_ALLOWLIST on each fixture init. The comment now names the real mechanism and file, and spells out the consequence: a response key behind a private flag still moves E2E snapshots even though the flag is off in production.
by Rob Lester
Succeeded
29373
48e2b5b2 Fixed the labs test-behaviour comment ref BER-3799 The comment claimed all flags in GA_FEATURES, BETA_FEATURES, and ALPHA_FEATURES are globally enabled during E2E tests, which was wrong on three counts: BETA_FEATURES and ALPHA_FEATURES don't exist (the constants are PUBLIC_BETA_FEATURES and PRIVATE_FEATURES), GA_FEATURES are always true everywhere rather than being a test behaviour, and the mechanism lives in enableAllLabsFeatures in test/utils/fixture-utils.js — not labs.js — which enables every key in WRITABLE_KEYS_ALLOWLIST on each fixture init. The comment now names the real mechanism and file, and spells out the consequence: a response key behind a private flag still moves E2E snapshots even though the flag is off in production.
by Rob Lester
Succeeded
29373
b61814d2 Fixed the labs test-behaviour comment ref BER-3799 The comment claimed all flags in GA_FEATURES, BETA_FEATURES, and ALPHA_FEATURES are globally enabled during E2E tests, which was wrong on three counts: BETA_FEATURES and ALPHA_FEATURES don't exist (the constants are PUBLIC_BETA_FEATURES and PRIVATE_FEATURES), GA_FEATURES are always true everywhere rather than being a test behaviour, and the mechanism lives in enableAllLabsFeatures in test/utils/fixture-utils.js — not labs.js — which enables every key in WRITABLE_KEYS_ALLOWLIST on each fixture init. The comment now names the real mechanism and file, and spells out the consequence: a response key behind a private flag still moves E2E snapshots even though the flag is off in production.
by Rob Lester
Succeeded
29373
d53ea255 Fixed the labs test-behaviour comment ref BER-3799 The comment claimed all flags in GA_FEATURES, BETA_FEATURES, and ALPHA_FEATURES are globally enabled during E2E tests, which was wrong on three counts: BETA_FEATURES and ALPHA_FEATURES don't exist (the constants are PUBLIC_BETA_FEATURES and PRIVATE_FEATURES), GA_FEATURES are always true everywhere rather than being a test behaviour, and the mechanism lives in enableAllLabsFeatures in test/utils/fixture-utils.js — not labs.js — which enables every key in WRITABLE_KEYS_ALLOWLIST on each fixture init. The comment now names the real mechanism and file, and spells out the consequence: a response key behind a private flag still moves E2E snapshots even though the flag is off in production.
by Rob Lester
Succeeded
29373
c38999f0 Fixed the labs test-behaviour comment ref BER-3799 The comment claimed all flags in GA_FEATURES, BETA_FEATURES, and ALPHA_FEATURES are globally enabled during E2E tests, which was wrong on three counts: BETA_FEATURES and ALPHA_FEATURES don't exist (the constants are PUBLIC_BETA_FEATURES and PRIVATE_FEATURES), GA_FEATURES are always true everywhere rather than being a test behaviour, and the mechanism lives in enableAllLabsFeatures in test/utils/fixture-utils.js — not labs.js — which enables every key in WRITABLE_KEYS_ALLOWLIST on each fixture init. The comment now names the real mechanism and file, and spells out the consequence: a response key behind a private flag still moves E2E snapshots even though the flag is off in production.
by Rob Lester
Succeeded
29373
df55a21b Added tests for the long_text byte bound ref BER-3799 The catalog package enforces 100% line/function/statement coverage, and the byte-bound change introduced its first real functions — byteLength and the refine callback — which the existing contract test never executed, so function coverage went to 0% and the task failed even though the test passed. These tests exercise the bound directly: a value at the limit, one byte over, a multibyte value that fits only when counted as characters, and a multibyte value that reaches the limit exactly. That last pair is the point of the whole change and is worth pinning here rather than only end-to-end, because it is pure logic and the character-vs-byte distinction is subtle. Coverage back to 100% (functions 2/2).
by Rob Lester
Succeeded
29373
df55a21b Added tests for the long_text byte bound ref BER-3799 The catalog package enforces 100% line/function/statement coverage, and the byte-bound change introduced its first real functions — byteLength and the refine callback — which the existing contract test never executed, so function coverage went to 0% and the task failed even though the test passed. These tests exercise the bound directly: a value at the limit, one byte over, a multibyte value that fits only when counted as characters, and a multibyte value that reaches the limit exactly. That last pair is the point of the whole change and is worth pinning here rather than only end-to-end, because it is pure logic and the character-vs-byte distinction is subtle. Coverage back to 100% (functions 2/2).
by Rob Lester
Failed
29373
8426068b Fixed the labs test-behaviour comment ref BER-3799 The comment named BETA_FEATURES and ALPHA_FEATURES, which don't exist — the constants are PUBLIC_BETA_FEATURES and PRIVATE_FEATURES. It also framed GA_FEATURES as test behaviour when they're always true everywhere, and pointed at labs.js for a mechanism that lives elsewhere: enableAllLabsFeatures in test/utils/fixture-utils.js enables every key in WRITABLE_KEYS_ALLOWLIST, and every fixture init runs it unconditionally. The comment now names the real mechanism and file so it can be verified, and spells out the consequence: a response key behind a private flag still changes E2E snapshots even though the flag is off in production.
by Rob Lester
Failed
29373
8426068b Fixed the labs test-behaviour comment ref BER-3799 The comment named BETA_FEATURES and ALPHA_FEATURES, which don't exist — the constants are PUBLIC_BETA_FEATURES and PRIVATE_FEATURES. It also framed GA_FEATURES as test behaviour when they're always true everywhere, and pointed at labs.js for a mechanism that lives elsewhere: enableAllLabsFeatures in test/utils/fixture-utils.js enables every key in WRITABLE_KEYS_ALLOWLIST, and every fixture init runs it unconditionally. The comment now names the real mechanism and file so it can be verified, and spells out the consequence: a response key behind a private flag still changes E2E snapshots even though the flag is off in production.
by Rob Lester