Overview - Ghost

Ghost

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
29485
d7aec802 Required the custom fields services on the members exporter Boot builds the custom fields services before the members service, so the exporter cannot observe them as absent. The module-level require plus the warn-and-degrade branch guarded a state that cannot occur, so the exporter is now a factory taking the definitions and values services, constructed in the members service's init() alongside the other late-resolved members. The labs flag alone decides whether custom field columns are included, which is what it was always meant to decide. The Admin API endpoint still unwraps definitions with a non-null assertion, because endpoint modules are constructed at import time and cannot take an injected instance without a much larger change. No behaviour change either way on the flag.
by Rob Lester
Succeeded
29485
11023d46 Required a custom fields service on MemberBREADService MemberBREADService's add() guarded its call into the custom fields service on the request body carrying a custom_fields key. The custom fields service is a required dependency of the members service, and boot constructs it before the members service, so an instance without one cannot exist in a running Ghost and the guard was protecting a state that cannot occur. The dependency is now also inverted: the members service previously received the custom fields module namespace and reached through it as customFieldsService.values on every call, which meant depending on a module-level binding that is undefined until init() runs, so it takes the values service itself as customFieldValues, resolved once in services/members/api.js at construction. Custom fields is initialised in initCore and the members API is built in initServices, so construction is where boot order is expressed rather than each call site late-binding through a namespace. The hand-written typedef restating the service's shape is replaced by a reference to the real exported CustomFieldValuesService type, matching how memberRepository and offersAPI are already typed in that file, because a restated structural typedef can drift from the service it describes and an imported one cannot. The unit fixtures previously built a service that could not exist in production, and now build it the way boot does, sharing a single stub so the factories in that file cannot drift apart. Nothing enforces the dependency at runtime, because a dependency that cannot be absent does not need a guard; making it non-optional in the type system belongs with converting the file to TypeScript. No behaviour change for any request.
by Rob Lester
Succeeded
29485
11023d46 Required a custom fields service on MemberBREADService MemberBREADService's add() guarded its call into the custom fields service on the request body carrying a custom_fields key. The custom fields service is a required dependency of the members service, and boot constructs it before the members service, so an instance without one cannot exist in a running Ghost and the guard was protecting a state that cannot occur. The dependency is now also inverted: the members service previously received the custom fields module namespace and reached through it as customFieldsService.values on every call, which meant depending on a module-level binding that is undefined until init() runs, so it takes the values service itself as customFieldValues, resolved once in services/members/api.js at construction. Custom fields is initialised in initCore and the members API is built in initServices, so construction is where boot order is expressed rather than each call site late-binding through a namespace. The hand-written typedef restating the service's shape is replaced by a reference to the real exported CustomFieldValuesService type, matching how memberRepository and offersAPI are already typed in that file, because a restated structural typedef can drift from the service it describes and an imported one cannot. The unit fixtures previously built a service that could not exist in production, and now build it the way boot does, sharing a single stub so the factories in that file cannot drift apart. Nothing enforces the dependency at runtime, because a dependency that cannot be absent does not need a guard; making it non-optional in the type system belongs with converting the file to TypeScript. No behaviour change for any request.
by Rob Lester
Succeeded
29485
d814cae6 Required a custom fields service on MemberBREADService MemberBREADService's add() guarded its call into the custom fields service on the request body carrying a custom_fields key. The custom fields service is a required dependency of the members service, and boot constructs it before the members service, so an instance without one cannot exist in a running Ghost and the guard was protecting a state that cannot occur. The unit fixtures previously built a service that could not exist in production, and now build it the way boot does, sharing a single stub so the factories in that file cannot drift apart. Removing the guard widens the members create path to depend on the custom fields module being initialised, which the boot sequence already guarantees by ordering. Nothing enforces the dependency at runtime, because a dependency that cannot be absent does not need a guard; making it non-optional in the type system belongs with converting the file to TypeScript. No behaviour change for any request.
by Rob Lester
Succeeded
29485
5a584a37 Required a custom fields service on MemberBREADService MemberBREADService's add() guarded its call into the custom fields service on the request body carrying a custom_fields key, but that guard only existed because the unit fixtures built the service without a customFieldsService at all. Boot always constructs it with its full dependency graph, so an instance without one cannot exist in production and the guard was protecting a shape only the tests could produce. The fixtures now build the service the way boot does, sharing a single stub so the two factories in that file cannot drift apart again, and namesValues answers false for an absent key rather than throwing, since nothing sent names no values. Nothing enforces the dependency at runtime on purpose: a wrong construction has one call site and fails loudly on first use, and an assertion that can only fire in a test is the same thing this removes. No behaviour change for any request.
by Rob Lester
Succeeded
29485
f39b51bc Required a custom fields service on MemberBREADService MemberBREADService's add() guarded its call into the custom fields service on the request body carrying a custom_fields key, but that guard only existed because the unit fixtures built the service without a customFieldsService at all. Boot always constructs it with its full dependency graph, so an instance without one cannot exist in production and the guard was protecting a shape only the tests could produce. The fixtures now build the service the way boot does, sharing a single stub so the two factories in that file cannot drift apart again, and namesValues answers false for an absent key rather than throwing, since nothing sent names no values. Nothing enforces the dependency at runtime on purpose: a wrong construction has one call site and fails loudly on first use, and an assertion that can only fire in a test is the same thing this removes. No behaviour change for any request.
by Rob Lester