Overview - Ghost

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
30014
83cf69a4 Updated advanced dialogs with latest main no ref Preserved controlled modal ownership while retaining the new CSV import support and its tests.
by Steve Larson
Succeeded
30014
1643384d Changed advanced settings dialogs to controlled components no ref The code injection, webhook, labs YAML editor, feature-toggle confirmation and universal import dialogs were the last NiceModal.create dialogs under settings/advanced. They now take an onClose prop and are rendered by the component that opens them, using SettingsModal's controlled onClose path that the routed settings dialogs already use. This removes five of the remaining NiceModal call sites so the provider and dependency can be torn down once the theme and membership dialogs follow. Dialogs opened from inside a settings group render through a small settings dialog portal whose host sits beside the settings layout. The settings groups and the fixed content wrapper each open a stacking context, so a SettingsModal rendered in place paints below the exit button and neighbouring groups; the portal keeps it where NiceModal's placeholder used to render. The webhook dialog opens from inside a routed dialog and does not need it. The universal importer and the automations feature-toggle confirmation had no acceptance coverage, so tests were added for both, and the code injection test now checks that nothing paints over the open dialog.
by Steve Larson
Succeeded
30014
4ff0cee0 Changed advanced settings dialogs to controlled components no ref The code injection, webhook, labs YAML editor, feature-toggle confirmation and universal import dialogs were the last NiceModal.create dialogs under settings/advanced. They now take an onClose prop and are rendered in-tree by the component that opens them, using SettingsModal's controlled onClose path that the routed settings dialogs already use. This removes five of the remaining NiceModal call sites so the provider and dependency can be torn down once the theme and membership dialogs follow. The universal importer and the automations feature-toggle confirmation had no acceptance coverage, so tests were added for both alongside the existing code injection, webhook and YAML editor tests.
by Steve Larson