tr
TryGhost
GitHub
Ghost
Workspace
GitHub
CI Pipeline Executions
Filtered
Runs
Demo
Insights
Compare tasks
Analytics
Sign in
Toggle sidebar
Overview
⌘K
Ghost
Loading workspace stats
Loading workspace insights...
Statistics interval
7 days
30 days
Latest CI Pipeline Executions
Status
Fix filter
Filter
Fuzzy
Filter range
Sort by
Sort by
Start time
Sort ascending
Sort descending
GitHub
Ghost
Workspace
Succeeded
30518
d5f0d3ed 🐛 Fixed tag results in admin search not opening the tag no ref Clicking a tag in the Cmd-K search modal did nothing. The Ember `tag` route aborts its transition when `tagDetailsReact` is on so React can own the URL, but an aborted transition never reaches `updateURL` — so a transition Ember itself started left the shared hash untouched and React never rendered anything. The search modal navigates by route name (`transitionTo('tag', slug)`), which is exactly the case that has no URL of its own. Write the React URL for named intents and park on `react-fallback`, matching what the posts/pages and editor routes already do behind their own flags. The tag route was the first flag-gated route and predates that handling. Parking also keeps `currentRouteName` honest, so returning to the same tag URL later is a real transition rather than a silent no-op. The existing search acceptance tests run with mirage labs `{}`, so they only covered the Ember-owned branch no production user reaches. The new acceptance test drives the real router with the flag on, mirroring the editor and posts equivalents.
by Steve Larson
S
Previous
Next