Run details

routerWorkspace

CI Pipeline Executions
- Current executionFailed
  schiller-manuel-link-memo-layer
- Runs and Agents
- TimelineBeta
- Configuration
- Self-Healing CI
- Project Graph
- Circular DependenciesEnterprise
- Resource Usage
- Analysis
- ConformanceEnterprise
Runs
- Current runFailed
- Tasks
- Resource Usage

Insights

Compare tasks
Analytics

fix(react-router): memoize the Link's merged ref callback The merged ref that fills a forwarded ref alongside the link's own ref was an inline closure, so every Link render produced a new callback and React detached and re-attached it: a consumer's callback ref was called with `null` and then the element again on each location-driven re-render (3 calls after one navigation instead of 1), and an object ref was cleared and refilled inside the commit. `useImperativeHandle(ref, ..., [])` on main only re-ran when the consumer's ref changed. The callback is now memoized with `useCallback` on the forwarded ref, which restores that contract: the consumer is notified on mount, when their ref changes and on unmount. A cleanup returned by a consumer callback is still passed through to React. Nothing reads `innerRef.current` after a detach without a re-attach, so the wrapper that would clear it on cleanup is left out (+19 gzip for no observable behavior). `areLinkPropsEqual` keeps the same rule but states it in two steps, since the nested condition read as if `children` were deep-compared: element props (`children`, handlers, `style`, ...) only match by reference, and only router options fall through to `deepEqual`. Tests pin all three: a stable callback ref stays at one call across a location change and is released when swapped, a returned cleanup runs on unmount instead of a `null` call, and a new JSX child or a cyclic element prop re-renders the Link instead of being compared deeply. The ref test fails on the previous commit with `expected 1 call, got 3`. Measurements (local: macOS arm64, Node 24.8.0, production React 19.2.3): - `react-router.minimal` gzip 86008 -> 86004 (-4). The comparator restructure alone is -2; `useCallback` without the cleanup wrapper is neutral, the wrapper would have been +19. - Mount of the 200-Link benchmark app, medians of 60 runs: 4.97 ms with `useImperativeHandle` (main's mechanism on top of this branch), 4.71 ms with the inline callback, 4.69 ms memoized. Retained heap per mounted app: -23 KB against `useImperativeHandle` (its layout effect keeps an effect node, a bound function and two deps arrays per fiber pair). - Paired client runner, 3 repeats, memoized vs `useImperativeHandle`: 12/13 workloads inconclusive, `rewrites` -4.6% [-9.0, -0.2]. Memoized vs the inline callback: +2.5% [1.4, 3.7] on `param-updaters` and +1.4% [0.4, 2.5] on `relative`, where every Link re-renders per navigation and pays the extra hook; the other 11 workloads are inconclusive. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3

Failed

e071e26e8405

99%

Completed tasks

700 of 701 completed.

<1%

Failed tasks

1 of 701 failed.

<1%

Not executed tasks

1 of 701 tasks were not executed.

2%

Cache hits

15 of 701 tasks used cache.

91%

Distribution saved time

15m 02s instead of 2h 48m 27s.

© 2026 - Nx Cloud

Terms of Service Privacy Policy Changelog Status Docs Contact Nx Cloud Pricing Company @NxDevTools

routerWorkspace