Loading workspace insights... Statistics interval
7 days30 daysLatest CI Pipeline Executions
1a3b541c 🐛 Fixed link selection in automations email editor (#29176)
closes https://linear.app/ghost/issue/NY-1394/
- Koenig portals its link input/toolbar to document.body, but the
automations email modal's Radix dialog is modal, so its focus trap
couldn't contain those portals — clicks and focus never reliably reached
them
- attempted a Koenig-side fix (render portals into a container inside
the dialog instead), but that surfaced a new focus fight between Radix's
trap and Lexical's own focus handling
- fixed in Ghost instead: the dialog is non-modal, and the rest of the
admin UI is made inert while it's open, so nothing outside the editor
can steal focus/clicks and Koenig's body-level portals work fine
- inert is also more robust for accessibility than a JS focus trap —
it's natively enforced by the browser, so background content is reliably
unreachable by keyboard and screen readers regardless of where Koenig
portals its UI
before - link input didn't work, and escape would close the entire
editor instead of the link input/list:
after - input works, scroll works, escape works, other koenig cards
still work. it's hard to demo but there was also an issue with my
original approach where if i just set `modal={false}`, then tab could
potentially move your control to the body (behind the editor). that's
the main reason for this larger fix:
