tr
TryGhost
GitHub
Ghost
Workspace
GitHub
CI Pipeline Executions
Filtered
Runs
Demo
Insights
Compare tasks
Analytics
Sign in
Toggle sidebar
Overview
⌘K
Ghost
Loading workspace stats
Loading workspace insights...
Statistics interval
7 days
30 days
Latest CI Pipeline Executions
Status
Fix filter
Filter
Fuzzy
Filter range
Sort by
Sort by
Start time
Sort ascending
Sort descending
Succeeded
29771
8b401e8e Improved boot time by dropping the date-fns barrel import ref https://github.com/TryGhost/Ghost/pull/29305 - a bisect of boot time found a ~120ms step at #29305, which moved the route-settings read path onto the adapter-backed store; the store's module graph reaches utils.ts, which imported the whole date-fns barrel (313 modules) - before that commit the boot path only loaded the date-fns/format subpath (35 modules) via the since-deleted settings-path-manager, so this was a straight regression rather than a newly introduced cost - format is only used to build the timestamped backup filename in getBackupRouteSettingsFilePath, whose only callers are FileStore.replace and S3RouteSettingsStore.replace - the routes.yaml upload path. Boot never runs it - hand-rolled the timestamp rather than switching to the subpath import: the subpath still loads 35 modules at boot, and leaves the barrel one "organise imports" away from silently re-landing. Removing the dependency instead makes that un-reintroducible - date-fns no longer resolves from ghost/core at all - yyyy-MM-dd-HH-mm-ss has no locale- or timezone-dependent tokens, so the output is unchanged for any valid Date
by Princi Ver...
P
Succeeded
29771
8b401e8e Improved boot time by dropping the date-fns barrel import ref https://github.com/TryGhost/Ghost/pull/29305 - a bisect of boot time found a ~120ms step at #29305, which moved the route-settings read path onto the adapter-backed store; the store's module graph reaches utils.ts, which imported the whole date-fns barrel (313 modules) - before that commit the boot path only loaded the date-fns/format subpath (35 modules) via the since-deleted settings-path-manager, so this was a straight regression rather than a newly introduced cost - format is only used to build the timestamped backup filename in getBackupRouteSettingsFilePath, whose only callers are FileStore.replace and S3RouteSettingsStore.replace - the routes.yaml upload path. Boot never runs it - hand-rolled the timestamp rather than switching to the subpath import: the subpath still loads 35 modules at boot, and leaves the barrel one "organise imports" away from silently re-landing. Removing the dependency instead makes that un-reintroducible - date-fns no longer resolves from ghost/core at all - yyyy-MM-dd-HH-mm-ss has no locale- or timezone-dependent tokens, so the output is unchanged for any valid Date
by Princi Ver...
P
Succeeded
29771
506fb8b2 Improved boot time by dropping the date-fns barrel import ref https://github.com/TryGhost/Ghost/pull/29305 - a bisect of boot time found a ~120ms step at #29305, which moved the route-settings read path onto the adapter-backed store; the store's module graph reaches utils.ts, which imported the whole date-fns barrel (313 modules) - before that commit the boot path only loaded the date-fns/format subpath (35 modules) via the since-deleted settings-path-manager, so this was a straight regression rather than a newly introduced cost - format is only used to build the timestamped backup filename in getBackupRouteSettingsFilePath, whose only callers are FileStore.replace and S3RouteSettingsStore.replace - the routes.yaml upload path. Boot never runs it - hand-rolled the timestamp rather than switching to the subpath import: that removes the last date-fns reference in ghost/core so the dependency goes too, and yyyy-MM-dd-HH-mm-ss has no locale- or timezone-dependent tokens, so the output is byte-identical - requiring FileStore.ts drops from ~189ms to ~52ms locally
by Princi Ver...
P
Previous
Next