tr
TryGhost
GitHub
Ghost
Workspace
GitHub
CI Pipeline Executions
Filtered
Runs
Demo
Insights
Compare tasks
Analytics
Sign in
Toggle sidebar
Overview
⌘K
Ghost
Loading workspace stats
Loading workspace insights...
Statistics interval
7 days
30 days
Latest CI Pipeline Executions
Status
Fix filter
Filter
Fuzzy
Filter range
Sort by
Sort by
Start time
Sort ascending
Sort descending
Failed
30017
e7196cb6 Cleaned preview modal file ending no ref This keeps the NiceModal cleanup free of trailing blank lines and satisfies the repository whitespace check.
by Steve Larson
S
Succeeded
30017
a2722349 Removed NiceModal from settings and Shade no ref Every settings dialog now renders as a controlled component, either from its route or from the component that opens it, so nothing is created or shown through NiceModal any more. This removes the NiceModal provider from the settings app, the NiceModal fallback paths from Shade's SettingsModal and the settings PreviewModalContent (onClose is now required on both), and the @ebay/nice-modal-react dependency from admin, Shade and the framework, along with its catalog entry. Shade's SettingsModal unit tests and story rendered through NiceModal only because that was the available mount path; they now render the modal directly with a controlled onClose.
by Steve Larson
S
Previous
Next