Overview - Ghost

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Succeeded
30304
b26993be Fixed collection flags being read for truthiness Stripe's SDK form-encodes its request bodies, so a checkout that switched tax collection off arrives carrying the string "false" rather than the boolean. The fake server read that flag for truthiness, and a string is truthy whichever word it holds, so it refused a checkout that had asked for no tax number at all and named a requirement the request had already met. The existing tests missed it because they post JSON, where the flag is a real boolean, so the refusal only appeared under the encoding Ghost actually uses. The completion helper read the same flags the same way and would have let a test answer a question the page never rendered. ref https://linear.app/ghost/issue/BER-3872
by Rob Lester
Succeeded
30304
4d050310 Added checkout collection to the fake Stripe server Stripe Checkout can be asked to collect a shipping address, a phone number or a tax number alongside the payment, and the fake server the end-to-end tests run against knew none of it. Anything built on top would have been tested against a server that accepted whatever it was sent, which is the opposite of what a fake is for. The rules it now enforces were measured against the live API at the version Ghost pins rather than read from the reference, which disagreed with the API in three of five probes. So a request the real Stripe would refuse now fails a test here first, including the one refusal that is easy to miss: a tax number cannot be collected for a customer Stripe may not rename. ref https://linear.app/ghost/issue/BER-3872
by Rob Lester
Succeeded
30304
4d050310 Added checkout collection to the fake Stripe server Stripe Checkout can be asked to collect a shipping address, a phone number or a tax number alongside the payment, and the fake server the end-to-end tests run against knew none of it. Anything built on top would have been tested against a server that accepted whatever it was sent, which is the opposite of what a fake is for. The rules it now enforces were measured against the live API at the version Ghost pins rather than read from the reference, which disagreed with the API in three of five probes. So a request the real Stripe would refuse now fails a test here first, including the one refusal that is easy to miss: a tax number cannot be collected for a customer Stripe may not rename. ref https://linear.app/ghost/issue/BER-3872
by Rob Lester
Succeeded
30304
0523d02f Added checkout collection to the fake Stripe server Stripe Checkout can be asked to collect a shipping address, a phone number or a tax number alongside the payment, and the fake server the end-to-end tests run against knew none of it. Anything built on top would have been tested against a server that accepted whatever it was sent, which is the opposite of what a fake is for. The rules it now enforces were measured against the live API at the version Ghost pins rather than read from the reference, which disagreed with the API in three of five probes. So a request the real Stripe would refuse now fails a test here first, including the one refusal that is easy to miss: a tax number cannot be collected for a customer Stripe may not rename. ref https://linear.app/ghost/issue/BER-3872
by Rob Lester