Overview - Ghost

7 days30 days

Latest CI Pipeline Executions

Fuzzy

Failed
30777
7f0bf37e Removed the limit service's dependency on Ghost's error library The service raises the errors its caller gives it, so that a caller recognises what it catches, and Admin supplies its own because Ghost's error library is written for the server. Two guards still reached for that library directly, which put it in the browser bundle for every Admin user and made those two the only errors a caller could not recognise. Neither can use the errors it was given. One complains that no error classes were supplied, and the other belongs to a function that is reached without a service at all. Both now raise a plain error, the way Ghost's own configuration does for the same reason, and the library is no longer a dependency of this package.
by Rob Lester
R
Failed
30777
6669e56a Changed the limit service to be constructed with the limits it applies Every caller built a service and loaded it on the next line, so the split between constructing one and telling it what to limit bought nothing and meant the object was briefly invalid. It takes its limits when it is built now, and a site with no limits is its own thing rather than a service that happens to be empty, which is what a self-hosted site has and what every site has until its host says otherwise. Ghost reads its limits where it needs them rather than holding one, because boot replaces the service once it knows what a site's limits are, and tests replace it again afterwards. Anything built before that happens, which is anything constructed as its module loads, is handed a view that reads the current service instead of whichever one existed when it was built.
by Rob Lester
R
Failed
30777
ae9f7cf1 Changed the limit service to be constructed with the limits it applies Every caller built a service and loaded it on the next line, so the split between constructing one and telling it what to limit bought nothing and meant the object was briefly invalid. It takes its limits when it is built now, and a site with no limits is its own thing rather than a service that happens to be empty, which is what a self-hosted site has and what every site has until its host says otherwise. Ghost reads its limits where it needs them rather than holding one, because boot replaces the service once it knows what a site's limits are, and tests replace it again afterwards. Anything built before that happens, which is anything constructed as its module loads, is handed a view that reads the current service instead of whichever one existed when it was built.
by Rob Lester
R
Succeeded
30777
c97f92bc Changed Ghost's limit service to TypeScript This file is where Ghost's own configuration meets the limit service, so unlike the count queries it cannot move into the package: it reads hostSettings, decides the help link, swallows a misconfiguration at boot rather than refusing to start, and hands out the singleton every model and endpoint asks for. What it can do is be checked. Ghost only typechecks TypeScript, so as JavaScript none of that wiring was seen by the compiler, and neither was the limit name that the route guard takes. Ghost does not permit TypeScript syntax that cannot be erased, so the service cannot keep exporting itself as the module. It now exports itself by default, which is how every other converted service here is consumed, and the callers that want the service rather than its two helpers read it from there.
by Rob Lester
R
Failed
30777
c97f92bc Changed Ghost's limit service to TypeScript This file is where Ghost's own configuration meets the limit service, so unlike the count queries it cannot move into the package: it reads hostSettings, decides the help link, swallows a misconfiguration at boot rather than refusing to start, and hands out the singleton every model and endpoint asks for. What it can do is be checked. Ghost only typechecks TypeScript, so as JavaScript none of that wiring was seen by the compiler, and neither was the limit name that the route guard takes. Ghost does not permit TypeScript syntax that cannot be erased, so the service cannot keep exporting itself as the module. It now exports itself by default, which is how every other converted service here is consumed, and the callers that want the service rather than its two helpers read it from there.
by Rob Lester
R