tr
TryGhost
GitHub
Ghost
Workspace
GitHub
CI Pipeline Executions
Filtered
Runs
Demo
Insights
Compare tasks
Analytics
Sign in
Toggle sidebar
Overview
⌘K
Ghost
Loading workspace stats
Loading workspace insights...
Statistics interval
7 days
30 days
Latest CI Pipeline Executions
Status
Fix filter
Filter
Fuzzy
Filter range
Sort by
Sort by
Start time
Sort ascending
Sort descending
Failed
30173
81c8f31d Reformatted branch with Oxfmt
by Steve Larson
S
Succeeded
30173
0babf246 Moved the site id middleware to TypeScript in shared middleware ref https://linear.app/ghost/issue/PLA-366/return-421-x-site-id-mismatch-from-ghosts-site-id-middleware `core/app.js` defined this handler inline, so the only way to assert its behaviour was a full `startGhost()` boot. PLA-366 changes its response contract and that contract deserves cheap direct coverage, so move it in alongside the other shared middleware, convert it and its test to TypeScript, and take the expected site id as an argument instead of reading config internally. Behaviour is unchanged. The maintenance handler stays in `core/app.js` — it is not what PLA-366 touches, and moving it would mean dealing with the untyped url service for no gain right now.
by Austin Bur...
A
Previous
Next