tr
TryGhost
GitHub
Ghost
Workspace
GitHub
CI Pipeline Executions
Current execution
Succeeded
slars/settings-membership-dialogs-controlled
Configuration
Self-Healing CI
Project Graph
Resource Usage
Analysis
Conformance
Runs
Current run
Succeeded
Tasks
Resource Usage
Insights
Compare tasks
Analytics
Sign in
Toggle sidebar
Changed membership settings dialogs to controlled components no ref The custom field, welcome email and welcome email customize dialogs were the last NiceModal.create dialogs in the membership and email settings areas. They now take an onClose prop and are rendered by the component that opens them: the two SettingsModal dialogs through the settings dialog portal so they paint above the settings chrome, and the customize dialog directly, since its EmailDesignModal is already a portalled Shade Dialog. With these converted, no settings dialog is created or shown through NiceModal any more, which clears the way to remove the provider, the dependency and the compatibility bridges.
nx run ghost-monorepo:lint:boundaries
⌘K
Succeeded
nx run ghost-monorepo:lint:boundaries
Click to copy
Linux
4 CPU cores
read-write
access token used
2b24004f
30016