tr
TryGhost
GitHub
Ghost
Workspace
GitHub
CI Pipeline Executions
Current execution
Failed
chore/limit-service-faults
Runs and Agents
Timeline
Beta
Configuration
Self-Healing CI
Project Graph
Circular Dependencies
Enterprise
Resource Usage
Analysis
Conformance
Enterprise
Runs
Current run
Succeeded
Tasks
Resource Usage
Insights
Compare tasks
Analytics
Sign in
Toggle sidebar
Changed the limit service to be built from settings that have been read Host settings arrive from Ghost(Pro) as strings in a single column, and nothing read them before handing them to the limit service. A maximum that is not a number survives that journey intact and then compares false against every count, so the limit reads as configured, is charged for, and is never enforced; the only way anyone finds out is a customer exceeding a limit they were sold. Reading them now happens in one place, which decides everything that makes a limit usable: whether its values can be read, whether a counted limit has anything to count, whether a list has anything on it, and whether a limit that resets has a period to reset against. The service takes what was read rather than raw configuration, so it can assume the limits it is handed already work, and the type it accepts can only be produced by reading a host's settings. How to count what a limit measures is passed apart from the configuration, because it is behaviour rather than configuration and a browser counts differently to a server. None of this can stop a site starting. A limit nobody can use cannot be applied either way, and refusing to boot over one would take a site off the air for a mistake made elsewhere, so each limit is read on its own and the ones that cannot be used are set aside and logged at error level. That also ends one limit taking every other limit down with it, which used to leave a site unlimited in ways nobody chose. ref BER-3952
nx run ghost-monorepo:lint:boundaries
⌘K
Succeeded
nx run ghost-monorepo:lint:boundaries
Click to copy
Linux
4 CPU cores
read-write
access token used
8d09179c
30779
GitHub
Ghost
Workspace