tr
TryGhost
GitHub
Ghost
Workspace
GitHub
CI Pipeline Executions
Current execution
Succeeded
slars/editor-shared-chip-picker
Runs and Agents
Configuration
Self-Healing CI
Project Graph
Circular Dependencies
Enterprise
Resource Usage
Analysis
Conformance
Enterprise
Runs
Current run
Succeeded
Tasks
Resource Usage
Insights
Compare tasks
Analytics
Sign in
Toggle sidebar
Moved both chip pickers onto one shared shell no ref The tags field and the authors field were near-copies of the same chips-in-a-field control, and had drifted: the authors field answered Escape on the input and stopped the key, and drew a chip as a badge wrapping a smaller remove button, while the tags field answered Escape on the document and made the whole chip the button. Both also named a listbox through `aria-controls` while it was not on screen. `shared/pickers/chip-picker.tsx` now owns the open and highlight state, the pointerdown and blur dismissal, the IME guard, Backspace removal, the Arrow, Enter and Tab keyboard, the field and dropdown surfaces and the combobox ARIA. The tag picker keeps the tag browse, its debounce and the create row; the authors picker keeps the staff browse, its rows and its load-error notice. The term the rows and the create offer read against is trimmed by default and normalised by the caller when it queries with something else, so an offer to create can never disagree with the query. The drift is settled on the tags field's side, and Escape is now claimed rather than left standing: a Radix layer registers its own capture listener at mount and so still answers the key first, but a settings pane listening on the window bubble bails on a prevented default, which is what keeps a pane from closing along with the list inside it. A chip is a single button named "Remove <name>", and `aria-controls` is written only while the list is open, with `aria-expanded` carrying the state either way.
nx run ghost-monorepo:lint:boundaries
⌘K
Succeeded
nx run ghost-monorepo:lint:boundaries
Click to copy
Linux
4 CPU cores
read-write
access token used
97ae02b2
30609
GitHub
Ghost
Workspace